From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion behave unintuitively when point is not at end of buffer Date: Mon, 04 Sep 2023 09:51:04 +0300 Organization: LINKOV.NET Message-ID: <86r0nexwh3.fsf@mail.linkov.net> References: <8635574n10.fsf@mail.linkov.net> <868rema032.fsf@mail.linkov.net> <83r0se4bwf.fsf@gnu.org> <87pm7xkqsd.fsf@catern.com> <83jzy419bk.fsf@gnu.org> <874jourckv.fsf@catern.com> <83lei6mxa0.fsf@gnu.org> <86wn1jutxv.fsf@mail.linkov.net> <83zg6eby5t.fsf@gnu.org> <83r0qjzj22.fsf@gnu.org> <86h6rccz9c.fsf@mail.linkov.net> <83v8fsw0r9.fsf@gnu.org> <86v8fruwur.fsf@mail.linkov.net> <83352vwb6v.fsf@gnu.org> <86edjfyx84.fsf@mail.linkov.net> <87bkeird9k.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39645"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 62700@debbugs.gnu.org, Spencer Baugh To: sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 04 08:52:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qd3Rv-000A8G-FC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Sep 2023 08:52:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qd3RV-0002c8-On; Mon, 04 Sep 2023 02:52:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd3RK-0002Zm-La for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 02:52:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qd3RK-00061h-Dt for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 02:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qd3RJ-0002X6-TG for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 02:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 06:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62700 X-GNU-PR-Package: emacs Original-Received: via spool by 62700-submit@debbugs.gnu.org id=B62700.16938103189723 (code B ref 62700); Mon, 04 Sep 2023 06:52:01 +0000 Original-Received: (at 62700) by debbugs.gnu.org; 4 Sep 2023 06:51:58 +0000 Original-Received: from localhost ([127.0.0.1]:48114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd3RF-0002Wl-Ku for submit@debbugs.gnu.org; Mon, 04 Sep 2023 02:51:57 -0400 Original-Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:47989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd3R9-0002WL-Po for 62700@debbugs.gnu.org; Mon, 04 Sep 2023 02:51:56 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 245BEE000A; Mon, 4 Sep 2023 06:51:41 +0000 (UTC) In-Reply-To: <87bkeird9k.fsf@catern.com> (sbaugh@catern.com's message of "Mon, 04 Sep 2023 00:30:16 +0000 (UTC)") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269212 Archived-At: >>> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el >>> index 539206a19e4..d079dc0bcdf 100644 >>> --- a/lisp/minibuffer.el >>> +++ b/lisp/minibuffer.el >>> @@ -2395,7 +2395,11 @@ minibuffer-completion-help >>> (prefix (unless (zerop base-size) (substring string 0 base-size))) >>> (base-prefix (buffer-substring (minibuffer--completion-prompt-end) >>> (+ start base-size))) >>> - (base-suffix (buffer-substring (point) (point-max))) >>> + (base-suffix >>> + (if (eq (alist-get 'category (cdr md)) 'file) >>> + (buffer-substring (save-excursion (or (search-forward "/" nil t) (point-max))) >>> + (point-max)) >>> + "")) >> >> As was found in bug#64903, this change broke completion-in-region. >> For example, with (setq completion-use-base-affixes t) >> if there is some text in the current buffer after point, >> then typing 'M-C-i' and selecting a candidate to insert to the buffer, >> it replaces all the text after point with an empty string. >> >> Before this change, the suffix was set to the text after point, >> and after inserting the selected candidate the suffix was >> re-inserted to the same buffer. > > How can this be the cause of bug#64903? Wasn't that bug reproduced on > Emacs 28? This change only went in to 29. bug#64903 is a related but completely separate case. The patch above went in to master, so in-buffer completion with non-nil completion-use-base-affixes is broken only in master, but fortunately not broken in emacs-29.