From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#65854: Multi-file replacement diff Date: Sat, 23 Sep 2023 20:36:02 +0300 Organization: LINKOV.NET Message-ID: <86r0movlkt.fsf@mail.linkov.net> References: <86sf7mgd54.fsf@mail.linkov.net> <86bke943tp.fsf@mail.linkov.net> <83jzswrios.fsf@gnu.org> <86o7i7oo9t.fsf@mail.linkov.net> <86sf7g548a.fsf@mail.linkov.net> <83pm2jkhsg.fsf@gnu.org> <86msxeu1q3.fsf@mail.linkov.net> <83zg1e7jq3.fsf@gnu.org> <86o7hunqyu.fsf@mail.linkov.net> <83jzsi5h1n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34573"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: me@eshelyaron.com, 65854@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 23 19:40:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qk6c6-0008pb-3n for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Sep 2023 19:40:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qk6bk-0000vl-FY; Sat, 23 Sep 2023 13:39:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qk6bi-0000vU-GL for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 13:39:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qk6bf-0002eS-Ck for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 13:39:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qk6bq-0007vL-6q for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 13:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2023 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65854-submit@debbugs.gnu.org id=B65854.169549077130396 (code B ref 65854); Sat, 23 Sep 2023 17:40:02 +0000 Original-Received: (at 65854) by debbugs.gnu.org; 23 Sep 2023 17:39:31 +0000 Original-Received: from localhost ([127.0.0.1]:40580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk6bL-0007uC-Je for submit@debbugs.gnu.org; Sat, 23 Sep 2023 13:39:31 -0400 Original-Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:42815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk6bJ-0007tq-Nl for 65854@debbugs.gnu.org; Sat, 23 Sep 2023 13:39:30 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id D12D340002; Sat, 23 Sep 2023 17:39:11 +0000 (UTC) In-Reply-To: <83jzsi5h1n.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Sep 2023 19:06:12 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271178 Archived-At: >> >> + However, when the file >> >> +is not visited in a buffer, or the buffer is not modified, still read >> >> +contents from the file." >> > >> > Seems to describe an implementation detail, and I don't think it >> > should be there. E.g., what if the file visited by the buffer no >> > longer exists? >> >> If the file visited by the buffer no longer exists, then >> the standard error is signaled. > > Which means in that case it is better to use the buffer text, no? Since replacement diffs are not supported in non-file buffers, better to signal an error for heads up.