From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#61396: diff mode could distinguish changed from deleted lines Date: Mon, 02 Oct 2023 19:56:36 +0300 Organization: LINKOV.NET Message-ID: <86r0mdp9uz.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18124"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 61396@debbugs.gnu.org, Samuel Wales To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 02 19:04:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qnML1-0004Wf-J0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Oct 2023 19:04:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnMKh-0001MT-Bl; Mon, 02 Oct 2023 13:03:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnMKf-0001LJ-F7 for bug-gnu-emacs@gnu.org; Mon, 02 Oct 2023 13:03:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnMKf-000235-7K for bug-gnu-emacs@gnu.org; Mon, 02 Oct 2023 13:03:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qnMKv-0000eK-S0 for bug-gnu-emacs@gnu.org; Mon, 02 Oct 2023 13:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Oct 2023 17:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61396 X-GNU-PR-Package: emacs Original-Received: via spool by 61396-submit@debbugs.gnu.org id=B61396.16962661852403 (code B ref 61396); Mon, 02 Oct 2023 17:04:01 +0000 Original-Received: (at 61396) by debbugs.gnu.org; 2 Oct 2023 17:03:05 +0000 Original-Received: from localhost ([127.0.0.1]:37843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnMK1-0000ch-G9 for submit@debbugs.gnu.org; Mon, 02 Oct 2023 13:03:05 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:47367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnMJz-0000cC-Jv for 61396@debbugs.gnu.org; Mon, 02 Oct 2023 13:03:04 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 0DE721C0005; Mon, 2 Oct 2023 17:02:38 +0000 (UTC) In-Reply-To: (Stefan Monnier via's message of "Mon, 04 Sep 2023 17:06:06 -0400") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271666 Archived-At: > - Second, `diff-refine-hunk` highlights the text actually added and the > text actually removed within modified lines, but not the place where > text is added/removed in the other version. > [ As pointed out by Juri (thanks for Cc'ing me, BTW) this is linked to > a comment I left in `smerge--refine-highlight-change`, tho that > comment was thinking of a slightly different feature (namely the > ability to jump from one version to the other, or the addition of > a "phantom" cursor highlighting the corresponding place in the other > version). ] > Here the problem is mostly that we don't have a standard way to > highlight a "place" (which is something that occupies 0 pixels on > screen). But we could follow the (not unanimously appreciated) lead > of `rectangle-mode` and insert a thin (highlighted) visual space to > mark those places. That should be not too hard to do, but it would > have to be optional I think because it'd tend to break alignment, so > some people may not find the upside significant enough to justify > the downsides. Ediff highlights the first character of the context. Logically this is not correct, but probably Ediff predates the ability of using a thin space like in `rectangle-mode`. Or maybe because it doesn't work on ttys.