From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#68214: Completion sorting customization by category Date: Sat, 06 Jan 2024 19:33:36 +0200 Organization: LINKOV.NET Message-ID: <86r0iuxu4f.fsf@mail.linkov.net> References: <86a5pnzst1.fsf@mail.linkov.net> <868r5630ft.fsf@mail.linkov.net> <8ebc33fb-d01f-4426-a716-69a11f6dfad1@daniel-mendler.de> <86le95m2ue.fsf@mail.linkov.net> <86sf3cjj6o.fsf@mail.linkov.net> <871qawrxh0.fsf@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2572"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 68214@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 06 18:43:35 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rMAhr-0000ZX-1y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jan 2024 18:43:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMAhH-0001WT-PX; Sat, 06 Jan 2024 12:42:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMAhF-0001W8-Es for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 12:42:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rMAhF-0005yv-6r for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 12:42:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rMAhK-0000Lu-6Q for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 12:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jan 2024 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68214 X-GNU-PR-Package: emacs Original-Received: via spool by 68214-submit@debbugs.gnu.org id=B68214.17045629691304 (code B ref 68214); Sat, 06 Jan 2024 17:43:02 +0000 Original-Received: (at 68214) by debbugs.gnu.org; 6 Jan 2024 17:42:49 +0000 Original-Received: from localhost ([127.0.0.1]:60252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMAh7-0000Ky-JY for submit@debbugs.gnu.org; Sat, 06 Jan 2024 12:42:49 -0500 Original-Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:59291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMAh5-0000Ki-ML for 68214@debbugs.gnu.org; Sat, 06 Jan 2024 12:42:48 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 8D77240003; Sat, 6 Jan 2024 17:42:33 +0000 (UTC) In-Reply-To: <871qawrxh0.fsf@daniel-mendler.de> (Daniel Mendler's message of "Fri, 05 Jan 2024 09:33:15 +0100") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277472 Archived-At: > If we are going with a solution which supports customizing arbitrary > metadata based on category, we could also adjust > `completion-metadata-get' and avoid the introduction of a separate > function `completion-metadata-override-get'. This will result in a > smaller and simpler code change overall. > > (defun completion-metadata-get (metadata prop) > "Get PROP from completion METADATA. > If the metadata specifies a completion category, the variables > `completion-category-overrides' and > `completion-category-defaults' take precedence." > (if-let (((not (eq prop 'category))) > (cat (alist-get 'category metadata)) > (over (completion--category-override cat prop))) > (cdr over) > (alist-get prop metadata))) This is what I already considered but hesitated to make this change since it modifies the default behavior. OTOH, probably there is no possible harm from this change. So I'll give this a try.