bug#69426: 29.2; Let eglot-rename suggest thing-at-point when renaming

bug#69426: 29.2; Let eglot-rename suggest thing-at-point when renaming

[Chmouel Boudjnah]

When using eglot-rename it asks for a new name (for the variable for
example) to rename to, it would be nice if there was a way to have the
current thing-at-point suggested as the new name.

Usually when renaming a variable you want to rename it to something that
is related to the current name with the defautl behavior you have to
type the current name manually.

I have a function like this that does it:

  (defun my-eglot-rename (newname)
    "Rename the current symbol to NEWNAME with initial input a."
    (interactive
     (list (read-from-minibuffer
            (format "Rename`%s' to: " (or (thing-at-point 'symbol t)
                                          "unknown symbol"))
            (or (thing-at-point 'symbol t) "") nil nil nil
            (symbol-name (symbol-at-point)))))
    (eglot--server-capable-or-lose :renameProvider)
    (eglot--apply-workspace-edit
     (jsonrpc-request (eglot--current-server-or-lose)
                      :textDocument/rename
`(,@(eglot--TextDocumentPositionParams)
                                             :newName ,newname))


which probably can work as advice to eglot-rename but it would be nice
if we can have this builtin.

bug#69426: 29.2; Let eglot-rename suggest thing-at-point when renaming

[Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Hello Chmouel,

Chmouel Boudjnah <chmouel@chmouel.com> writes:

> When using eglot-rename it asks for a new name (for the variable for
> example) to rename to, it would be nice if there was a way to have the
> current thing-at-point suggested as the new name.

AFAICT, that is more or less already the case: eglot-rename uses the
name of the symbol at point as the minibuffer default value.

> Usually when renaming a variable you want to rename it to something that
> is related to the current name with the defautl behavior you have to
> type the current name manually.

Just hit M-n and it's there :)


Best,

Eshel

bug#69426: 29.2; Let eglot-rename suggest thing-at-point when renaming

[Chmouel Boudjnah]

On Tue, Feb 27, 2024 at 2:29 PM Eshel Yaron <me@eshelyaron.com> wrote:

> > Usually when renaming a variable you want to rename it to something that
> > is related to the current name with the defautl behavior you have to
> > type the current name manually.
>
> Just hit M-n and it's there :)

Thanks Eshel, I always forget about that one! I guess we can close this then!

Cheers,
Chmouel

bug#69426: 29.2; Let eglot-rename suggest thing-at-point when renaming

[Eli Zaretskii]

> From: Chmouel Boudjnah <chmouel@chmouel.com>
> Date: Tue, 27 Feb 2024 13:59:26 +0100
> 
> When using eglot-rename it asks for a new name (for the variable for
> example) to rename to, it would be nice if there was a way to have the
> current thing-at-point suggested as the new name.
> 
> Usually when renaming a variable you want to rename it to something that
> is related to the current name with the defautl behavior you have to
> type the current name manually.

You don't need to type the current name manually, you can instead
press <DOWN> arrow or M-n, and Emacs will "type" the current name for
you.  So after that you only need to edit the current name to the new
name.  Isn't that what you wanted?

bug#69426: 29.2; Let eglot-rename suggest thing-at-point when renaming

[Chmouel Boudjnah]

On Tue, Feb 27, 2024 at 2:33 PM Eli Zaretskii <eliz@gnu.org> wrote:
> You don't need to type the current name manually, you can instead
> press <DOWN> arrow or M-n, and Emacs will "type" the current name for
> you.  So after that you only need to edit the current name to the new
> name.  Isn't that what you wanted?

Yes that's correct, I forgot this was something minibuffer via
next-history-element offers across emacs, thank you!

Chmouel,

bug#69426: 29.2; Let eglot-rename suggest thing-at-point when renaming

[Eli Zaretskii]

> Cc: 69426@debbugs.gnu.org
> From: Chmouel Boudjnah <chmouel@chmouel.com>
> Date: Tue, 27 Feb 2024 14:32:25 +0100
> 
> On Tue, Feb 27, 2024 at 2:29 PM Eshel Yaron <me@eshelyaron.com> wrote:
> 
> > > Usually when renaming a variable you want to rename it to something that
> > > is related to the current name with the defautl behavior you have to
> > > type the current name manually.
> >
> > Just hit M-n and it's there :)
> 
> Thanks Eshel, I always forget about that one! I guess we can close this then!

Done.