From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69168: [BUG] 30.0.50; pp-emacs-lisp-code produces invalid elisp for backquoted forms Date: Sat, 09 Mar 2024 10:49:15 +0200 Message-ID: <86r0gjyelw.fsf@gnu.org> References: <877cj5y1qg.fsf@gmail.com> <87mss1nono.fsf@web.de> <87v86dt9xl.fsf@web.de> <86bk85xd21.fsf@gnu.org> <87le79t1j6.fsf@web.de> <87y1b4vw7f.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2322"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69168@debbugs.gnu.org, monnier@iro.umontreal.ca, iarchivedmywholelife@gmail.com To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 09 09:50:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1risPf-0000S2-1d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Mar 2024 09:50:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1risPb-0002U6-5m; Sat, 09 Mar 2024 03:50:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1risPV-0002Sp-Rk for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 03:50:30 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1risPV-00004s-JB for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 03:50:29 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1risQ2-0003c5-38 for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 03:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Mar 2024 08:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69168 X-GNU-PR-Package: emacs Original-Received: via spool by 69168-submit@debbugs.gnu.org id=B69168.170997420513802 (code B ref 69168); Sat, 09 Mar 2024 08:51:02 +0000 Original-Received: (at 69168) by debbugs.gnu.org; 9 Mar 2024 08:50:05 +0000 Original-Received: from localhost ([127.0.0.1]:60573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1risP7-0003aX-2S for submit@debbugs.gnu.org; Sat, 09 Mar 2024 03:50:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1risP4-0003Zs-Lb for 69168@debbugs.gnu.org; Sat, 09 Mar 2024 03:50:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1risOS-0008Gf-QX; Sat, 09 Mar 2024 03:49:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8abH50pC2Ziazr67RplXmN0Xk2R1Ao9a1l/g2qj1ueU=; b=qMww8/BR+MMf xTkGNzmZ7yZaned+E2EBSZ0ffVZy1jXWo3Y0RQ8Mf2QTuLm5CjNBuFmmjk6nU+9Z0SGJCETDwU9Nm oe/S0hh5KkQeCAiGHwEC50WNKHfM2jWDF6hnZ13OqonmSnaPu9vaE1GKlPp0tykUfWqiFIOrP04Vc LPg9GZUC9qXVzAEiMEJU3czpSfzKo0iHrf2yPANVTE8iUSCEjMX5sM7w4SUDHb9nlNgMD7FkXI3Bc Ecswao3JIf0BtmYA50t+Wcc4bP4F6oH4rSNC6ZSFidkmCZPDAXFJpayIdUXpO4HNDxdmV6PxqG017 tmFTpf/NkE64GoOzklJm1w==; In-Reply-To: <87y1b4vw7f.fsf@web.de> (message from Michael Heerdegen on Thu, 29 Feb 2024 03:30:12 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281307 Archived-At: > From: Michael Heerdegen > Cc: Stefan Monnier , > iarchivedmywholelife@gmail.com, 69168@debbugs.gnu.org > Date: Thu, 29 Feb 2024 03:30:12 +0100 > > Michael Heerdegen writes: > > > One from me: I'm working on a second patch for pp that will make > > printing of backquote forms using the nicer `X syntax. > > Here is the additional patch. No Wayman, maybe you can try if it gives > good results? > > This change seems quite straightforward, and I tried to avoid to make > the code less efficient. For me, it seems to give good results. > Please (Eli), if names and comments are bad English, please feel free to > suggest a better wording. LGTM, with one minor nit: > + (not (consp l)) ; SEXP is a dotted list > + ;; Is SEXP is of a form like (ELT... . ,X) ? The "Is SEXP is" part seems to have one "is" too many... I suggest Does SEXP have a form like (ELT... . ,X) ? Thanks.