From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#70007: [PATCH] native JSON encoder Date: Sat, 30 Mar 2024 16:45:54 +0000 Message-ID: <86r0fr3by5.fsf@gmail.com> References: <1BF559D1-DB9F-4FEB-90ED-72E0EFD76424@gmail.com> <86wmpphrg7.fsf@gnu.org> <4589243D-C11A-45C1-AF3E-6F4A5BADEB54@gmail.com> <864jcrindg.fsf@gnu.org> <291DD5F1-85B8-4647-A40A-EBBD4C51E253@gmail.com> <8634sbijfx.fsf@gnu.org> <2CF47DA5-A65B-47C4-A28A-6FEE1469BD13@gmail.com> <86cyrdfuai.fsf@gnu.org> <3139C8FE-5C67-4FE3-B940-F449DA73E76C@gmail.com> <86le5zdfbi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 70007@debbugs.gnu.org Cancel-Lock: sha1:Z2gUAVUf3EQ3GFdPO6Gp7AbrwZM= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 30 17:47:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqbrO-0006pN-FD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Mar 2024 17:47:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqbrB-0004uC-Bk; Sat, 30 Mar 2024 12:47:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqbrA-0004u3-CD for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 12:47:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqbrA-00029n-40 for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 12:47:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rqbrC-0001fC-2k for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 12:47:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <1BF559D1-DB9F-4FEB-90ED-72E0EFD76424@gmail.com> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Mar 2024 16:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17118171796291 (code B ref -1); Sat, 30 Mar 2024 16:47:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Mar 2024 16:46:19 +0000 Original-Received: from localhost ([127.0.0.1]:46104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqbqV-0001dO-Bl for submit@debbugs.gnu.org; Sat, 30 Mar 2024 12:46:19 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:38404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqbqT-0001cP-5Q for submit@debbugs.gnu.org; Sat, 30 Mar 2024 12:46:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqbqL-0004iY-QS for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 12:46:09 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqbqK-00024z-Iz for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 12:46:09 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rqbqF-0005Fo-TM for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 17:46:03 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 3 X-Spam_score: 0.3 X-Spam_bar: / X-Spam_report: (0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282386 Archived-At: On Sat 30 Mar 2024, Richard Copley wrote: > On 30/03/2024 14:22, Mattias Engdegård wrote: >> I made the changes above and installed it on master, as well as a sweeping removal of all things Jansson. > > Hi Mattias, > A clean build fails with a linker error: > > CCLD temacs > /usr/bin/ld: /tmp/cc4stUid.ltrans15.ltrans.o: in function `main': > :(.text.startup+0x39a9): undefined reference to `syms_of_json' > collect2: error: ld returned 1 exit status > make[2]: *** [Makefile:739: temacs] Error 1 Commit 1135ce461d18 ("Always enable native JSON support and remove Jansson references") removed json.o from configure.ac, but did not add it in Makefile.in to ensure it is always built. Adding json.o to base_obj there appears to fix the build. AndyM