unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 70322-done@debbugs.gnu.org, geza.herman@gmail.com
Subject: bug#70322: 30.0.50; format-seconds with %z doesn't handle zero input correctly
Date: Wed, 10 Apr 2024 17:01:56 +0300	[thread overview]
Message-ID: <86r0fduxij.fsf@gnu.org> (raw)
In-Reply-To: <871q7djqtk.fsf@gmx.net> (message from Stephen Berman on Wed, 10 Apr 2024 15:21:59 +0200)

> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: Géza Herman <geza.herman@gmail.com>,
>   70322@debbugs.gnu.org
> Date: Wed, 10 Apr 2024 15:21:59 +0200
> 
> On Wed, 10 Apr 2024 16:00:30 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
> 
> >> From: Herman, Géza <geza.herman@gmail.com>
> >> Cc: Herman Géza <geza.herman@gmail.com>,
> >>  70322@debbugs.gnu.org
> >> Date: Wed, 10 Apr 2024 14:44:52 +0200
> >> 
> >> 
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >> 
> >> > Does the patch below give good results?
> >> 
> >> Yes, both yours and Stephen's patch fix the problem
> >
> > Thanks.
> >
> > Stephen, any argumentation for which one is better?
> 
> AFAICT both give the same results, but since yours specifically targets
> the case where %z is used, which directly addresses the bug report, it
> is conceptually the better fix.

Thanks, so I've now installed my change, and I'm closing this bug.





      reply	other threads:[~2024-04-10 14:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10  9:59 bug#70322: 30.0.50; format-seconds with %z doesn't handle zero input correctly Herman, Géza
2024-04-10 11:23 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-10 11:58 ` Eli Zaretskii
2024-04-10 12:44   ` Herman, Géza
2024-04-10 13:00     ` Eli Zaretskii
2024-04-10 13:21       ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-10 14:01         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86r0fduxij.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70322-done@debbugs.gnu.org \
    --cc=geza.herman@gmail.com \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).