From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: luangruo@yahoo.com, 70038@debbugs.gnu.org
Subject: bug#70038: 29.3.50; Shift up/down in buffer with images on M-x other-window with some fonts
Date: Wed, 17 Apr 2024 15:58:08 +0300 [thread overview]
Message-ID: <86r0f4gn8f.fsf@gnu.org> (raw)
In-Reply-To: <838b8ff4-36f2-476f-acef-6f331867bb1d@gmx.at> (message from martin rudalics on Wed, 17 Apr 2024 10:02:12 +0200)
> Date: Wed, 17 Apr 2024 10:02:12 +0200
> Cc: luangruo@yahoo.com, 70038@debbugs.gnu.org
> From: martin rudalics <rudalics@gmx.at>
>
> > I hope this is now more clear.
>
> Thanks. So when we enter the part headed by
>
> if ((w->optional_new_start || window_frozen_p (w))
>
> then the single aim is apparently to make sure that the cursor line
> remains fully visible.
Yes. If it isn't, we will either move point or, if even that is
impossible, ignore the request to preserve window-start.
> When we enter that part because window_frozen_p (w) is set, we ignore
> the scroll margins because we assume that preserving the window start
> position is more important in this situation.
>
> When we enter that part because w->optional_new_start was set, we assume
> that the caller ('recenter', 'delete-other-windows-internal') has done
> its part to obey the scroll margins but still might have failed to keep
> the cursor visible.
>
> Is that interpretation correct?
No, we actually check that point doesn't end up inside scroll margins
(search for "Some people insist"), and move point or reject the
window-start if it did.
> If so, it might make sense to put some
> explanation into a comment for that part because, at least for me, it's
> a priori not clear that the same treatment is wanted for keeping the
> previous start position of a window and for one that has been explicitly
> changed. I've spent almost an hour to arrive at the conclusion above.
> Things like this comment in 'delete-other-windows-internal'
>
> /* We need to do this, so that the window-scroll-functions
> get called. */
> w->optional_new_start = true;
>
> were distracting even further.
Where would you like to put the comment, and what should that comment
say?
next prev parent reply other threads:[~2024-04-17 12:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 20:25 bug#70038: 29.3.50; Shift up/down in buffer with images on M-x other-window with some fonts Ramon Diaz-Uriarte
2024-03-28 5:58 ` Eli Zaretskii
2024-03-28 7:52 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 8:36 ` Eli Zaretskii
2024-03-28 16:12 ` Ramon Diaz-Uriarte
2024-03-28 16:59 ` Ramon Diaz-Uriarte
2024-03-28 17:24 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 19:50 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-31 18:43 ` Ramon Diaz-Uriarte
2024-04-06 12:33 ` Eli Zaretskii
2024-04-06 14:08 ` Eli Zaretskii
2024-04-06 14:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-07 8:24 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-07 9:13 ` Eli Zaretskii
2024-04-07 10:12 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-07 11:28 ` Eli Zaretskii
2024-04-08 9:07 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13 10:10 ` Eli Zaretskii
2024-04-14 8:31 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-14 9:28 ` Eli Zaretskii
2024-04-15 9:23 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 13:54 ` Eli Zaretskii
2024-04-17 8:02 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-17 12:58 ` Eli Zaretskii [this message]
2024-04-28 8:51 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-28 9:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-29 9:47 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-29 12:51 ` Eli Zaretskii
2024-04-11 13:56 ` Ramon Diaz-Uriarte
2024-04-11 15:36 ` Eli Zaretskii
2024-04-12 16:43 ` Ramon Diaz-Uriarte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r0f4gn8f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70038@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).