From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71401: dired-async-mode breaks dired-vc-rename-file Date: Sun, 16 Jun 2024 19:40:31 +0300 Organization: LINKOV.NET Message-ID: <86r0cwsvgw.fsf@mail.linkov.net> References: <86msnmvc5d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4476"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Charles Choi , 71401@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 16 19:11:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sItPT-00010z-VH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jun 2024 19:11:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sItPC-0001h5-SL; Sun, 16 Jun 2024 13:11:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sItPB-0001gk-JE for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 13:11:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sItPB-00075W-AX for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 13:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sItPB-0003L4-PG for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 13:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jun 2024 17:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71401 X-GNU-PR-Package: emacs Original-Received: via spool by 71401-submit@debbugs.gnu.org id=B71401.171855782012693 (code B ref 71401); Sun, 16 Jun 2024 17:11:01 +0000 Original-Received: (at 71401) by debbugs.gnu.org; 16 Jun 2024 17:10:20 +0000 Original-Received: from localhost ([127.0.0.1]:44643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sItOU-0003Ia-TI for submit@debbugs.gnu.org; Sun, 16 Jun 2024 13:10:19 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIt8i-0002Th-J5; Sun, 16 Jun 2024 12:54:01 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id BFE61E0003; Sun, 16 Jun 2024 16:53:29 +0000 (UTC) In-Reply-To: <86msnmvc5d.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jun 2024 11:33:02 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287340 Archived-At: tags 71401 wontfix close 71401 30.0.50 thanks >> **** Title >> dired-async-mode breaks dired-vc-rename-file >> >> **** Description >> If dired-vc-rename-file is t and dired-async-mode is enabled, then >> renaming a version controlled file such that the version control >> software is aware of it will fail. >> >> **** Environment >> Emacs 29.3 >> >> **** Steps to Reproduce >> 1. Set dired-vc-rename-file to t >> 2. Enable dired-async-mode. >> 3. With a git repo, rename a file via Dired. >> >> **** Expected Result >> The renamed file should be reflected in git. >> >> **** Actual Result >> The file is renamed and considered deleted by git. > > Juri, could you please look into this? It took me a while to find that dired-async-mode is implemented in the package emacs-async. Then tried to rename with Wdired, and it works. Then tried to rename with R, and it fails with: Debugger entered--Lisp error: (wrong-type-argument stringp nil) make-process(:name "emacs" :buffer # :stderr # ... async-start-process("emacs" ... apply(async-start-process "emacs" ... async-start((lambda nil (require 'cl-lib) (require 'dired-aux) ... dired-async-create-files(dired-rename-file "Move" ... dired-async--smart-create-files(... dired-create-files(dired-rename-file "Move" ... dired-do-create-files(move dired-rename-file "Move" nil t "Rename") dired-do-rename(nil) funcall-interactively(dired-do-rename nil) command-execute(dired-do-rename) Then noticed that this backtrace doesn't include the function that uses dired-vc-rename-file. So I disabled dired-vc-rename-file, and got the same error. This means that the bug is not in Emacs and should be reported to the maintainers of the emacs-async package.