From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted Date: Mon, 24 Jun 2024 09:27:52 +0300 Organization: LINKOV.NET Message-ID: <86r0cmg9wf.fsf@mail.linkov.net> References: <86tthzwgsw.fsf@mail.linkov.net> <86msnkyt7c.fsf@mail.linkov.net> <30404984-e7ac-4f92-a194-06438dbf2d03@gutov.dev> <867cemquey.fsf@gnu.org> <864j9qqpfx.fsf@gnu.org> <86tthqp2zc.fsf@gnu.org> <86tthnzp19.fsf@mail.linkov.net> <10881a4d-5b44-4b7e-9686-d6f7bf3ddace@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33030"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , 71466@debbugs.gnu.org, me@eshelyaron.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 24 08:50:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLdWu-0008TK-Jo for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jun 2024 08:50:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLdWe-0003yf-5b; Mon, 24 Jun 2024 02:50:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLdWc-0003vw-My for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 02:50:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLdWc-0000FC-4D for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 02:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLdWc-0000CF-LP for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 02:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2024 06:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71466 X-GNU-PR-Package: emacs Original-Received: via spool by 71466-submit@debbugs.gnu.org id=B71466.1719211746637 (code B ref 71466); Mon, 24 Jun 2024 06:50:02 +0000 Original-Received: (at 71466) by debbugs.gnu.org; 24 Jun 2024 06:49:06 +0000 Original-Received: from localhost ([127.0.0.1]:42742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLdVh-0000AD-OP for submit@debbugs.gnu.org; Mon, 24 Jun 2024 02:49:06 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:57909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLdVf-00009Y-Ij for 71466@debbugs.gnu.org; Mon, 24 Jun 2024 02:49:04 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id BDC881BF204; Mon, 24 Jun 2024 06:48:54 +0000 (UTC) In-Reply-To: <10881a4d-5b44-4b7e-9686-d6f7bf3ddace@gutov.dev> (Dmitry Gutov's message of "Thu, 20 Jun 2024 20:35:47 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287823 Archived-At: >> So what is the decision? Maybe better to keep xref-revert-buffer >> as a wrapper around the new function xref--revert-buffer? > > That should work, though at the expense of duplicating some code. I still don't understand how duplicating revert-buffer +(defun xref-revert-buffer () + "Refresh the search results in the current buffer." + (declare (obsolete revert-buffer "30.1")) + (interactive) + (let (restore-functions) + (when (boundp 'revert-buffer-restore-functions) + (run-hook-wrapped 'revert-buffer-restore-functions + (lambda (f) (push (funcall f) restore-functions) nil))) + (prog1 (xref--revert-buffer) + (mapc #'funcall (delq nil restore-functions))))) can be better than what Eshel proposed with an alias: + (define-obsolete-function-alias 'xref-revert-buffer #'revert-buffer "30.1")