From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing changes Date: Sat, 14 Sep 2024 10:12:27 +0300 Message-ID: <86r09miu90.fsf@gnu.org> References: <640746f7-fa1c-dfb9-aaab-f9d8effdf64f@gutov.dev> <02b37700-a48d-4a7c-8e61-b37dfbabc062@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24711"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 62940@debbugs.gnu.org, fgunbin@fastmail.fm To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 14 09:13:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1spMxt-0006IH-Bn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Sep 2024 09:13:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spMxi-0000TL-N8; Sat, 14 Sep 2024 03:12:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spMxf-0000TB-Uf for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 03:12:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spMxf-0006vm-LK for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 03:12:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=p9otjhzS0OcvOBCW7y52gdp/UE0gaWoycNPmXHenSL4=; b=FB4/D2xtbDKvqED+CZ9pXcfHKrNhiH8GtWYl+M4wcJx3RsIVSNmq7ahQX+zprErJs5PdknIeCzOyCS5g+kvA1odtjLEkluEfMqqMcPCC+Sli1XZtrdvZtM+p1zlU57og4LzE+8rLpOE9w7XUk+okShy0yOE6tyawutztH8kQPKOInR4hoIV2mWs+1C8X4ZEnySWpWG/+SVr6yFfH0OXqIvKj6VX7IHT5PG2w7Kd638NCvUTlmiXO7DoxxGHocXLH3RgiZYjzopcII7/JeebtMUzqieDv23P9XRM81XmUfbAczsvzSFyIjCU4hGPq1vxhFTR5cgJ/VM2Y9zRFlEwmGA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1spMxp-0001T1-PN for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 03:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2024 07:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62940 X-GNU-PR-Package: emacs Original-Received: via spool by 62940-submit@debbugs.gnu.org id=B62940.17262979685618 (code B ref 62940); Sat, 14 Sep 2024 07:13:01 +0000 Original-Received: (at 62940) by debbugs.gnu.org; 14 Sep 2024 07:12:48 +0000 Original-Received: from localhost ([127.0.0.1]:44605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spMxb-0001SX-QN for submit@debbugs.gnu.org; Sat, 14 Sep 2024 03:12:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spMxZ-0001SC-Bd for 62940@debbugs.gnu.org; Sat, 14 Sep 2024 03:12:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spMxJ-0006um-RN; Sat, 14 Sep 2024 03:12:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=p9otjhzS0OcvOBCW7y52gdp/UE0gaWoycNPmXHenSL4=; b=Wuls8CxG536L QTf5WsdBgrX/97P5GrZ3wc4MigsSmbt/cR+m2hcyhRB5E59AlGRd7sDxmEetalXW9jxd0dydK2QNx 7Jmt+6PkVxfdIZFFqyQzQcxuTw1r6VwFbIBP3Ab/XG+7PVG1Fi6USf92OQT9IHwWuKLCrWQU6QEe2 rTRcsDBeO5g8/OhPGnjfnkJSm8whDsuMgdDlyNEnjFv29YfoeevOjOb7ZY8ZtWiH7RSlgLc7c2/43 9/whrP+aUt7pNBfsOq3BxF79+HJyS4G/XBchxs+b6NYpjaVuEIldtbSp4bjYF7svmVvw0SMC69jqD 6wr1ijn5seCP+xlRtDRiQA==; In-Reply-To: <02b37700-a48d-4a7c-8e61-b37dfbabc062@gutov.dev> (message from Dmitry Gutov on Sat, 14 Sep 2024 05:11:48 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291692 Archived-At: > Cc: 62940@debbugs.gnu.org, Filipp Gunbin > Date: Sat, 14 Sep 2024 05:11:48 +0300 > From: Dmitry Gutov > > > (vc-git-log-outgoing): Use vc-git-pushed-revision. > > * lisp/vc/vc-hg.el (vc-hg-pushed-revision): Add. > > * lisp/vc/vc.el (vc-default-pushed-revision): Add new backend function > > with default implementation returning nil. > > Am I too used to Git, or should this be called upstream-revision or > origin-revision? upstream-revision is definitely better than vc-default-pushed-revision, since some VCSes don't even have the "push" operation. More importantly, this change must be accompanied with a suitable update of the user manual, where we should explain what commit is suggested as the default. "Last pushed revision" is somewhat vague and inaccurate, because the user could switch branches or remotes, or do something else. We should find a more accurate description. Also, the doc string of vc-root-diff needs to be updated with this information. > Maybe we would prefer to keep the current suggestion as the first > default, and have the upstream as the second suggestion (on M-n)? For > backward compatibility anyway. Sounds like a good idea to me.