From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64055: [WIP Patch] Enable editing commit messages - vc-git-modify-change-comment Date: Fri, 18 Oct 2024 08:26:09 +0300 Message-ID: <86r08enfri.fsf@gnu.org> References: <87pm5yo4m7.fsf@gmail.com> <87legmnq4l.fsf@gmail.com> <87r090o8cl.fsf@melete.silentflame.com> <874j5vgypf.fsf@melete.silentflame.com> <787fb692-db24-4682-871b-5a52d31a1249@gutov.dev> <87ed4obs1b.fsf@melete.silentflame.com> <87o73sad24.fsf@melete.silentflame.com> <877ca63ln5.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33423"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Morgan.J.Smith@outlook.com, rpluim@gmail.com, 64055@debbugs.gnu.org, dmitry@gutov.dev To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 18 07:27:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1fWF-0008Yf-0u for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Oct 2024 07:27:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1fVg-0006x4-Vj; Fri, 18 Oct 2024 01:26:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1fVZ-0006vr-7o for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 01:26:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1fVY-0007R1-67 for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 01:26:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=OMPbK0vx22hinsU+cOT1Bl0q0nCnKmPI+vi2MYG3Mco=; b=YS5qYOLoKXD/JV88/GuzcLqqE2Tqf1QTt+kaq/W/77sAxhEmEMkp2oi85whGT8Y6AaJMRM1ry4CEEZcBhOk0HU/PWKNR4t/6dd9J+vIDfreH4fJ6jZzbO2G8z9Q3/2PDE+hN5imlgcsM5K1Xpl6ifU4qTsHDy3rmiCWtukDQXTdWeU1tLvwmBOtOr67bXVMMwMEvIQU1VmwhLi1FlEoed+Nn86riVkCVQeB9GqiOjpoYe8voZ7wvaJIITQRsu75AQEBrc1nQMvu78UNBIGuNdqAduR0Hv5KM8rpki2WM2HECtGtJ3qH73BxzUsCTQ87lUVrcYtQr40Cp3l4C0ziD+Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1fVt-0002QH-Mx for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 01:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Oct 2024 05:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.17292292049265 (code B ref 64055); Fri, 18 Oct 2024 05:27:01 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 18 Oct 2024 05:26:44 +0000 Original-Received: from localhost ([127.0.0.1]:36703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1fVc-0002PM-4Z for submit@debbugs.gnu.org; Fri, 18 Oct 2024 01:26:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1fVZ-0002P4-Pn for 64055@debbugs.gnu.org; Fri, 18 Oct 2024 01:26:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1fV6-0007Nk-3S; Fri, 18 Oct 2024 01:26:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OMPbK0vx22hinsU+cOT1Bl0q0nCnKmPI+vi2MYG3Mco=; b=cPta4P/aufp+ CF9uTZOm4PYc1pNW6sgzknryBEAFHjqB7sbtF4csCQWQRKoPPUNNjyvML+22Gv4dUgQuemLOrnwwF hJLvdKkQC1q/3Zkm2zK4fFzhpETAvxC99dZkeDn7LHinFG+UQtyIrXrOufYUrSlgnRGAqVUjr0J65 nHehyfLecB3exFlXhvGmmPJu2Xyfv5hmhnRGE4W/RTUs5GsXAWdU/MrTOdvCm4PgIfgFlHnottgE0 83/iEomYFkN01UKFdtfZRpYkAjlb8DfJQQ4+SKx3ZzTMdZ7H42nwcbFnsdALCpoTy6xlRCYa6loUk gO67ApwMhoDHReSqrAOS0g==; In-Reply-To: <877ca63ln5.fsf@melete.silentflame.com> (message from Sean Whitton on Thu, 17 Oct 2024 21:27:10 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293759 Archived-At: > Cc: Morgan Smith , Robert Pluim , > Dmitry Gutov > From: Sean Whitton > Date: Thu, 17 Oct 2024 21:27:10 +0800 > > Hello, > > On Thu 10 Oct 2024 at 10:48am +08, Sean Whitton wrote: > > > I would appreciate opinions comparing adding a new get-change-comment > > VC backend function with something like the WIP I posted. > > I went with adding a backend function. That's now on master. With the > other changes I've made, I believe that all that remains for this bug is > implementing vc-git-modify-change-comment based on our discussion. Thanks. The commit log message for the changes doesn't mention the bug number; please always remember to do that in the future. In this case, the discussion leading to the change is long and significant, so including a pointer to it is important for future forensics. More importantly, why are we installing changes in VC that are supported by a single backend? This is against the VC design principles. Let's please install soon implementations for other relevant backends. I think this should be very simple, but if you need help for some backends, feel free to ask for it. Btw, since CVS has an existing command-line option to amend the log message of a particular commit, I wonder whether the design that goes through a separate backend function which extracts the comment first is valid.