bug#74001: 31.0.50; loaddefs-generate does not ignore Darwin dylib files.

bug#74001: 31.0.50; loaddefs-generate does not ignore Darwin dylib files.

[Malcolm Purvis]

loaddefs-generate skips over files that include module-file-suffix 
values from the list of load suffices.  The regexp of suffices to 
skip is missing the Darwin suffix, "dylib".

 
In GNU Emacs 31.0.50 (build 1, x86_64-apple-darwin24.0.0, NS 
appkit-2566.00 Version 15.0.1 (Build 24A348)) of 2024-10-07 built 
on lamechWindowing system distributor 'Apple', version 10.3.2566 
System Description:  macOS 15.0.1  Configured using: 
 'configure 
 --enable-locallisppath=/usr/local/share/emacs/site-lisp 
 --infodir=/usr/local/Cellar/emacs-head@31/31.0.50_1/share/info/emacs 
 --prefix=/usr/local/Cellar/emacs-head@31/31.0.50_1 --without-x 
 --without-dbus --with-native-compilation --with-imagemagick 
 --with-modules --with-gnutls --with-rsvg --with-xml2 
 --with-xwidgets --with-webp --with-ns --disable-ns-self-contained 
 'CFLAGS=-O2 -march=native -pipe -DFD_SETSIZE=10000 
 -DDARWIN_UNLIMITED_SELECT' 'LDFLAGS=-L/usr/local/lib/gcc/14 
 -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include 
 -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include'' 
 

-- 
		    Malcolm Purvis <malcolm@purvis.id.au>

bug#74001: 31.0.50; loaddefs-generate does not ignore Darwin dylib files.

[Charalampos Mitrodimas]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: multipart/mixed; boundary="=-=-=", Size: 3 bytes --]

bug#74001: 31.0.50; loaddefs-generate does not ignore Darwin dylib files.

[Eli Zaretskii]

> From: Malcolm Purvis <malcolm@purvis.id.au>
> Date: Fri, 25 Oct 2024 17:36:37 +1100
> 
> loaddefs-generate skips over files that include module-file-suffix 
> values from the list of load suffices.  The regexp of suffices to 
> skip is missing the Darwin suffix, "dylib".

Thanks, fixed on the emacs-30 branch, and closing the bug.

bug#74001: 31.0.50; loaddefs-generate does not ignore Darwin dylib files.

[Charalampos Mitrodimas]

Hi Malcolm,

On 10/25/24 07:36, Malcolm Purvis wrote:
> loaddefs-generate skips over files that include module-file-suffix 
> values from the list of load suffices.  The regexp of suffices to skip 
> is missing the Darwin suffix, "dylib".

It seems that commit 28268e47d844215b11f9a731d2bedb58bee0b343 addressed 
this if I get this right.


>
>
> In GNU Emacs 31.0.50 (build 1, x86_64-apple-darwin24.0.0, NS 
> appkit-2566.00 Version 15.0.1 (Build 24A348)) of 2024-10-07 built on 
> lamechWindowing system distributor 'Apple', version 10.3.2566 System 
> Description:  macOS 15.0.1  Configured using: 'configure 
> --enable-locallisppath=/usr/local/share/emacs/site-lisp 
> --infodir=/usr/local/Cellar/emacs-head@31/31.0.50_1/share/info/emacs 
> --prefix=/usr/local/Cellar/emacs-head@31/31.0.50_1 --without-x 
> --without-dbus --with-native-compilation --with-imagemagick 
> --with-modules --with-gnutls --with-rsvg --with-xml2 --with-xwidgets 
> --with-webp --with-ns --disable-ns-self-contained 'CFLAGS=-O2 
> -march=native -pipe -DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT' 
> 'LDFLAGS=-L/usr/local/lib/gcc/14 -I/usr/local/opt/gcc/include 
> -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include 
> -I/usr/local/opt/jpeg/include''
>

                 C. Mitrodimas

bug#74001: 31.0.50; loaddefs-generate does not ignore Darwin dylib files.

[Eli Zaretskii]

> Cc: 74001@debbugs.gnu.org
> Date: Fri, 25 Oct 2024 10:38:32 +0000
> From: Charalampos Mitrodimas <charmitro@posteo.net>
> 
> Hi Malcolm,
> 
> On 10/25/24 07:36, Malcolm Purvis wrote:
> > loaddefs-generate skips over files that include module-file-suffix 
> > values from the list of load suffices.  The regexp of suffices to skip 
> > is missing the Darwin suffix, "dylib".
> 
> It seems that commit 28268e47d844215b11f9a731d2bedb58bee0b343 addressed 
> this if I get this right.

Maybe I'm missing something, but how do you see that the above commit
took care of this issue?