From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71909: 30.0.60; Date: Wed, 30 Oct 2024 17:35:36 +0200 Message-ID: <86r07x4n93.fsf@gnu.org> References: <865xtnhyn6.fsf@foxmail.com> <58c79a62-cd21-4ff5-8e81-a9ba3e9b2097@imayhem.com> <86plnj56li.fsf@gnu.org> <3b0ad17c-aa6e-421c-a17a-453bf0483023@imayhem.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36973"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71909@debbugs.gnu.org To: Cecilio Pardo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 30 16:36:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6AkB-0009Sf-KL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Oct 2024 16:36:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6Ajr-0007x1-Pj; Wed, 30 Oct 2024 11:36:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6Ajq-0007wo-Cy for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2024 11:36:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6Ajq-0003ue-4w for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2024 11:36:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=VlpRMHmm+Z02UozbGObUlvz1iytOUv/tee3zgxgp+P4=; b=fQ1SyX2bGh/Zh4EHsfl4RwyrTeOqt8bGLykM59peOKkpyknMYlZ539SYWxMozAGef6fSM4YNiXLiCZe9WnV/VF3mgXWi5/beRax6QGdAkBtixiG8rbq5DP/BG3NGSY5yC88f7QyYVFDlN4sVR0TC8xQs0+49yGVdOEacoZkTA2Lh8n6Fe4SDc4nMoltpbpIM+nKzG6aFw0nAyNm0ooAFs+GF5wZfQHZGxhNFpbfQk1dCQZOCPejKZzpPGrwWsm1CVWiZGJvJ34pF4AVqLRc9L1BcJXhSWxaTwElwrrcPUSONkkmlzocX9jSuF7lk/OFg3dsqWD+anTTlavcL5RlAsA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6Ajp-0006ET-VW for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2024 11:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Oct 2024 15:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71909 X-GNU-PR-Package: emacs Original-Received: via spool by 71909-submit@debbugs.gnu.org id=B71909.173030255123949 (code B ref 71909); Wed, 30 Oct 2024 15:36:01 +0000 Original-Received: (at 71909) by debbugs.gnu.org; 30 Oct 2024 15:35:51 +0000 Original-Received: from localhost ([127.0.0.1]:35706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6Aje-0006ED-IY for submit@debbugs.gnu.org; Wed, 30 Oct 2024 11:35:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6Ajc-0006E3-Co for 71909@debbugs.gnu.org; Wed, 30 Oct 2024 11:35:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6AjW-0003sV-1V; Wed, 30 Oct 2024 11:35:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VlpRMHmm+Z02UozbGObUlvz1iytOUv/tee3zgxgp+P4=; b=DRjIFTaefiFN 2WUdINKZL5Kmvq4yFDnUktbFpuLXto9gkoSMVPDiKl4GwiiSmcr2MnfGt4/CsVOGe8eFBOYmCxvVw 8b4eI7aJERp8z2ho+CrRT42TrE1rVtV5SVjzfRKYtw7mZ6GGub/twc6kD4zPNIpdMpzdPhbAisuOq 0tMYjMvo0Us0GNJVrAZQzL5jdMtOAyxr60NGX+3HrfXok/EOVmHazaOqRdr2b9zsL6p4prWv46XRs hkCtIVNG+r2qoUQpnFAS4OkqyXcbLn6M5Js1QCeODJ4DKHgOF4fO2o4RxvFrJ7hKMqnwhroooKcSr ejQ2bGI0n5MKBofdFRyLzg==; In-Reply-To: <3b0ad17c-aa6e-421c-a17a-453bf0483023@imayhem.com> (message from Cecilio Pardo on Wed, 30 Oct 2024 10:05:08 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294565 Archived-At: > Date: Wed, 30 Oct 2024 10:05:08 +0100 > From: Cecilio Pardo > > >> The image conversion is done using GdiPlus functions, which are > >> already used on w32image.c, but are static. I have splitted this file > >> into .c and .h, to be able to reuse those definitions. The image > >> conversion requires that native image functions are activated. > > > > What happens with yank-media if the user disables native image APIs? > > Do we signal an error or is there some graceful degradation (like > > using another MIME type)? > > The ability to yank DIBV5 will be lost. If there is no alternative such > as PNG or image/*, then yank can't be done. Is this because w32-use-native-image-API set to nil disables loading of GDI+? If so, we could load it even if w32-use-native-image-API is nil, but just return false from w32_can_use_native_image_api. This would allow us to use the GDI+ functions needed for yanking, but not those needed for image display. Does this make sense? > > Why a unibyte string? Is this always binary data or something? If > > this could be text (e.g., text/html), then a unibyte string is not the > > best choice. > > It can be binary, but not always. Is unibyte ok for binary cases? Yes. But we need to document that in the doc string. > I can > treat text/* differently, and make exceptions for types like image/svg+xml. That'd be much better. > > In any case, if the function must return a unibyte string in some > > cases, that should be mentioned in the doc string, because callers > > will otherwise not expect to get a unibyte string. Also, where will > > this unibyte string be decoded? > > In the binary case, is there any decoding to do? No.