From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Thu, 05 Dec 2024 09:31:39 +0200 Message-ID: <86r06my49w.fsf@gnu.org> References: <86wmgfzhgc.fsf@gnu.org> <86zflay7hh.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27952"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, 73862@debbugs.gnu.org, aaronjensen@gmail.com To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 05 08:32:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJ6LH-00075q-HY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Dec 2024 08:32:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJ6LE-0004tq-3h; Thu, 05 Dec 2024 02:32:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ6LC-0004td-QX for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 02:32:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJ6LC-00028u-Hy for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 02:32:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=ehQVoonyEk6tsDwUyjfi+ktb5PHpunSY/qOxUFvzMLc=; b=nrA2tHMYnvPn4kVZ5coEVp377reJDL0M4sUnJuZ6RUeGLg/ZGoCBWMfWQLLi9ONH6p/e342uF/gfqsYJbSD4LelJ48UvSkn318MRrHHSZXmogFntZO9ge6Hd0TPHhpjhrcSq5vEXLGvmeC/J2KA7UZIki376qgOojYKsMT60qN68I0PX0UM16IBrBdSbNS9CmF/of1n6opJ/N6cPnG4/nbPwaDH7xpPzOiQpmJvTTE5Lxsm9fkUpBEX+hHtXjl1BBF6MZJoKN4L7bsTa/58Vnf5evzzizm5ueyDwH/1keF2f1qCiSorWvlgYnhQT0q9HAj2+CeEW3PjgmvNJRro8sw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJ6LC-0004yl-CO for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 02:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2024 07:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173338391219120 (code B ref 73862); Thu, 05 Dec 2024 07:32:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 5 Dec 2024 07:31:52 +0000 Original-Received: from localhost ([127.0.0.1]:37979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ6L2-0004yK-0v for submit@debbugs.gnu.org; Thu, 05 Dec 2024 02:31:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ6L0-0004y2-3D for 73862@debbugs.gnu.org; Thu, 05 Dec 2024 02:31:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ6Kt-00027v-EI; Thu, 05 Dec 2024 02:31:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ehQVoonyEk6tsDwUyjfi+ktb5PHpunSY/qOxUFvzMLc=; b=mew02rWFUsPT 7JfcjVpS8OzaYO5aIy35LbNaFSel9iAV4RsSUhRVH0lK1eg5IClZvtINaxwZafd5SMPDF3e+lCzXe AgXI/06eTPtlBeJFxAZhJoUyelwsWpbLq5yOQqP2TvCj0iNcAyRUoGUg/sF9o79ZNrh36PVey5CTn TG+ivxv/nAMN/xupR5EVzixuhjpNQ29/rmSGPECKGgUTZCmtMILVfNTx9kpt8xdOQhkFHNycPi/g9 7wldyLA9wHOg7BT4qmDLWfniF+RYvEPd/rwOhksgi2Cw7RAoTf3lRepKYhiWhUs0ttzl7QqA+yTJm NyRStuxNWi4Ipoy3RCeN6A==; In-Reply-To: (message from Eshel Yaron on Thu, 05 Dec 2024 07:50:38 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296447 Archived-At: > From: Eshel Yaron > Cc: Aaron Jensen , trevor.m.murphy@gmail.com, > 73862@debbugs.gnu.org > Date: Thu, 05 Dec 2024 07:50:38 +0100 > > > If what you see is the same as Eshel, I will ask you the same > > question: shouldn't you apply face-remapping to the 2 new faces > > instead of the 'header-line' face from which they both inherit? > > What happens if you do define remapping for those two new faces? > > At least to me, it's not clear what you mean by "should". Existing code > remaps the header-line face with good results (prior to this change), so > if we now "should" remap something else instead to get the same results, > that means this is a breaking change. Is that intended? If so, OK, if > not, shouldn't it be fixed? :) Let's first understand the scope of the problem, shall we? If remapping the two new faces does what you want, then the only problem is in backward-incompatible nature of this change, when face remapping is considered. If remapping the two new faces does NOT do what you want, the problem is elsewhere. More to the point you raise: when we introduced mode-line-active face, the same happened with the 2 mode-line faces. We should indeed decide whether we need to support remapping the parent mode-line and header-line faces, but at least for mode line we don't, since Emacs 29.