From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74966: 31.0.50; Crash report (using igc on macOS) Date: Sat, 21 Dec 2024 09:51:41 +0200 Message-ID: <86r0618odu.fsf@gnu.org> References: <86a5cqkc2g.fsf@gnu.org> <86o716ah09.fsf@gnu.org> <87ikrejok5.fsf@protonmail.com> <86cyhm9m9a.fsf@gnu.org> <87seqihyex.fsf@protonmail.com> <864j2xa5x0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10691"; mail-complaints-to="usenet@ciao.gmane.io" Cc: spd@toadstyle.org, pipcet@protonmail.com, acorallo@gnu.org, monnier@iro.umontreal.ca, 74966@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 21 08:52:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOuHd-0002eE-5B for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Dec 2024 08:52:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOuHM-0004TW-En; Sat, 21 Dec 2024 02:52:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOuHL-0004TG-7B for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 02:52:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOuHK-00010p-VQ for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 02:52:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=TnYFheSUKx40bvW8Yl7RWQz2rxLnom2V0GBQqeLoIsc=; b=llWfgB5f5V+0hEspbIDlaIQlDz2cWLbMqQwBdRjuEvHP9y7tdDG6+NLiVqy+FOrwpKvjnzqUOLOWdCrsQKMeaHwjqDVDL4pbPAqNXu1q2qXdygY0y/9zR6p83xJM1pQEV91MSZ27Nb5XzWTNvfs4MHhRlFSrO3t3z5XCq/hdPXFgfQM4gpX6MbIb3ui8iLGxGq/01a9pr6mAYICYJmbrINKw45razd71hA7We1NK8m7Rz08WgzMqMgwBkmiWSM559yrJJToHUT4mi1hbn92WYj/DhkxxvfqUkIi9NgP4Jwv65wrUpg0tZgHYsHkEUUzbkOxpLJkLShzrPlAgj9AS3A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOuHJ-0002cH-QA for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 02:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2024 07:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74966 X-GNU-PR-Package: emacs Original-Received: via spool by 74966-submit@debbugs.gnu.org id=B74966.173476751310042 (code B ref 74966); Sat, 21 Dec 2024 07:52:01 +0000 Original-Received: (at 74966) by debbugs.gnu.org; 21 Dec 2024 07:51:53 +0000 Original-Received: from localhost ([127.0.0.1]:45093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOuHB-0002bt-Ba for submit@debbugs.gnu.org; Sat, 21 Dec 2024 02:51:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOuH7-0002bZ-Te for 74966@debbugs.gnu.org; Sat, 21 Dec 2024 02:51:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOuH2-0000yA-2j; Sat, 21 Dec 2024 02:51:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=TnYFheSUKx40bvW8Yl7RWQz2rxLnom2V0GBQqeLoIsc=; b=iqIm2skRrK2/0ssLKgP/ AZ2rUSrlQbxMELuXTPp8Ipy7ZOmy0M1f6J48MbMaOvZKyjmVv93SKWxk2fz/mZvfBJIL4QjHrvZ1N QcXEZkcpsOaAGy7IXyt50YQkH5lM+E3If/0MHfpgEX+7Vu/XNXxsxRTMAV+KsldbDGMud0G5AVzvO QYHQlHIXT9pRYtVmQjlaJsQPro7WJb7Fmt2V551SkSxYmL7gFTyrNyiUxnPmLbnQfv1WYDFow7HAo zUwNLVL2FWn2RALdlZMzG5Ab2HcW4jY7QC4xAC/LpcG2GzxmHX1bKGAo88ZA47appvMLa1A5Twn00 XbdVfr25v4aa0g==; In-Reply-To: (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Sat, 21 Dec 2024 08:08:40 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297494 Archived-At: > From: Gerd Möllmann > Cc: Pip Cet , spd@toadstyle.org, acorallo@gnu.org, > monnier@iro.umontreal.ca, 74966@debbugs.gnu.org > Date: Sat, 21 Dec 2024 08:08:40 +0100 > > Eli Zaretskii writes: > > >> I agree that the docfile hack in general is very hairy territory. It > >> might be safer to simply accept the wrong docstrings for now, and Gerd's > >> patch does that, IIUC. Can we just apply that for now and add a FIXME? > > > > Maybe, but I'd like first to understand better the "wrong docstrings" > > situations. > > Maybe I can explain this. The current error's cause is that nativecomp > currently (wrongly) assumes that it never needs an offset into DOC, so > it reused Lisp_Subr::doc for its own purposes, namely as an index into a > vector contained in an .eln file. The doc string of a function is found > at that index. > > Pip's patch changes nativecomp code stores the said index from above in > a new Lisp_Subr::doc_index, and makes it possible to fix the wrong > assumption from above, Nativecomp of course has to check which of the > now two members it has to use, which Pip does. > > Renaming Lisp_Subr::doc to Lisp_Object::doc_offset is a nice extra, IMO, > because it makes it clearer what the member contains. OK, thanks. I'd like Andrea to chime in first and see if he can fix this on the nativecomp side. Also, Stefan said something about using a Lisp_Object for the value? And finally, does what you wrote explain the "wrong docstrings" situation, or does it only explain the crash you saw? If the former, I'm afraid I'm still missing something, because I don't understand how this could cause a wrong docstring to be used.