From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Omar =?UTF-8?Q?Antol=C3=ADn?= Camarena Newsgroups: gmane.emacs.bugs Subject: bug#45035: 28.0.50; Command completion annotations show minibuffer keybindings Date: Sun, 06 Dec 2020 20:50:04 -0600 Message-ID: <86pn3mpbxf.fsf@matem.unam.mx> References: <87k0ty2xnw.fsf@matem.unam.mx> <875z5gdkky.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28020"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) Cc: 45035@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 07 03:51:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1km6cU-00075s-91 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Dec 2020 03:51:22 +0100 Original-Received: from localhost ([::1]:37682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km6cS-0001NS-VS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 21:51:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1km6cB-0001Ln-4Y for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 21:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1km6cA-0003Xo-11 for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 21:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1km6cA-0002xv-0V for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 21:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Omar =?UTF-8?Q?Antol=C3=ADn?= Camarena Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Dec 2020 02:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45035 X-GNU-PR-Package: emacs Original-Received: via spool by 45035-submit@debbugs.gnu.org id=B45035.160730941311298 (code B ref 45035); Mon, 07 Dec 2020 02:51:01 +0000 Original-Received: (at 45035) by debbugs.gnu.org; 7 Dec 2020 02:50:13 +0000 Original-Received: from localhost ([127.0.0.1]:51849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km6bN-0002wA-8U for submit@debbugs.gnu.org; Sun, 06 Dec 2020 21:50:13 -0500 Original-Received: from gauss.matem.unam.mx ([132.248.17.1]:34465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km6bL-0002vw-QA for 45035@debbugs.gnu.org; Sun, 06 Dec 2020 21:50:12 -0500 Original-Received: from Dell.localhost.localdomain (unknown [187.207.131.206]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: omar) by gauss.matem.unam.mx (Postfix) with ESMTP id 3A6855421F; Sun, 6 Dec 2020 20:50:07 -0600 (CST) In-Reply-To: <875z5gdkky.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 05 Dec 2020 22:51:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195199 Archived-At: > Thanks, I think your idea is correct. But I'm not sure if > minibuffer-completion-help is the right place for wrapping in > with-minibuffer-selected-window. This means that all calls of > annotation-function will be in the original buffer, whereas > only read-extended-command--annotation needs such wrapping. Oh, that's a very good point. Probably it would be best to leave minibuffer-completion-help as is, and change only read-extended-command--annotation. > Or do you care that such wrapping will be called for every command > in read-extended-command--annotation? Then instead of annotation-function > you could try to use a new function affixation-function that is called > only once, so you could add wrapping to it. My Emacs doesn't have affixation-function yet, so I don't really know anything about it. -- Omar