From: "H. Dieter Wilhelm" <dieter@duenenhof-wilhelm.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 45318@debbugs.gnu.org, Richard Stallman <rms@gnu.org>
Subject: bug#45318: 28.0.50; mark-paragraph
Date: Sun, 03 Jan 2021 23:29:00 +0100 [thread overview]
Message-ID: <86pn2lk637.fsf@duenenhof-wilhelm.de> (raw)
In-Reply-To: <87wnxdhh54.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 19 Dec 2020 17:53:11 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Richard Stallman <rms@gnu.org> writes:
>
>> Create a buffer in Fundamental mode, insert the text
>>
>> this is
>> a test
>>
>> with no newline at the end, put point at the end, and type M-h.
>>
>> It does not set the mark.
>
> It's this bit:
>
> ;; don't activate the mark when at eob
> ((and (eobp) (> numeric-arg 0)))
I'm sorry for the mistake. Here's the correction of M-h for above
bug report:
modified lisp/textmodes/paragraphs.el
@@ -401,8 +401,9 @@ mark-paragraph
(goto-char (mark))
(forward-paragraph arg)
(point))))
- ;; don't activate the mark when at eob
- ((and (eobp) (> numeric-arg 0)))
+ ;; don't activate the mark when at eob in an empty paragraph
+ ;; with a positive ARG
+ ((and (eobp) (bolp) (> numeric-arg 0)))
(t
(unless (save-excursion
(forward-line 0)
But I would like to extend this solution for the following case: (and
(eobp) (bolp)). The current implementation of M-h is doing nothing (for
positive arguments) because - formally - the cursor sits in an "empty"
paragraph and there are no further paragraphs below.
But in this situation applying M-h clearly shows the user's intention to
mark the paragraph above the cursor (and possibly further ones above
when typing M-hhhh).
What is your opinion?
Thank you
> commit eb090f65ceb0ae8a90829e911694348583135ba5
> Now added to the Cc's.
Thank you Lars
Dieter
--
Best wishes
H. Dieter Wilhelm
Zwingenberg, Germany
next prev parent reply other threads:[~2021-01-03 22:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 5:11 bug#45318: 28.0.50; mark-paragraph Richard Stallman
2020-12-19 16:53 ` Lars Ingebrigtsen
2021-01-03 22:29 ` H. Dieter Wilhelm [this message]
2021-01-04 9:19 ` Lars Ingebrigtsen
2021-01-05 22:27 ` H. Dieter Wilhelm
2021-01-07 12:11 ` Lars Ingebrigtsen
2021-04-04 1:01 ` Stefan Kangas
2021-10-11 12:15 ` Stefan Kangas
2021-10-16 17:33 ` H. Dieter Wilhelm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pn2lk637.fsf@duenenhof-wilhelm.de \
--to=dieter@duenenhof-wilhelm.de \
--cc=45318@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).