From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers Date: Thu, 18 Nov 2021 20:06:31 +0200 Organization: LINKOV.NET Message-ID: <86pmqxuymw.fsf@mail.linkov.net> References: <87bl44qz5o.fsf@gmail.com> <87wnmgk6r7.fsf@gmail.com> <87tugrmi1j.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5053"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Matthias Meulien , 51016@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 18 19:09:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnlqR-000197-IG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 19:09:11 +0100 Original-Received: from localhost ([::1]:44786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnlqP-000613-UD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 13:09:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnlqH-00060e-W9 for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 13:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnlqH-0004xO-Nn for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 13:09:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnlqH-0001S6-Jb for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 13:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Nov 2021 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51016 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51016-submit@debbugs.gnu.org id=B51016.16372588985506 (code B ref 51016); Thu, 18 Nov 2021 18:09:01 +0000 Original-Received: (at 51016) by debbugs.gnu.org; 18 Nov 2021 18:08:18 +0000 Original-Received: from localhost ([127.0.0.1]:37147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnlpZ-0001Qj-Oa for submit@debbugs.gnu.org; Thu, 18 Nov 2021 13:08:17 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:55897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnlpX-0001QN-0E for 51016@debbugs.gnu.org; Thu, 18 Nov 2021 13:08:16 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 07BD3240009; Thu, 18 Nov 2021 18:08:06 +0000 (UTC) In-Reply-To: <87tugrmi1j.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 05 Nov 2021 03:51:20 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220340 Archived-At: >> I updated the patch after a week using it. Outlines headers are now >> updated for diff comming from Git even when diff-font-lock-prettify is >> nil. > > Thanks for the patch and the thorough case for reproduction. I've now > applied it to Emacs 29 (with some trivial changes). As noticed in bug#51809, outline-cycle is not bound on hunk headings anymore, only on file headings. It seems the problem is somewhere here: (setq diff-outline-regexp (concat "\\(^diff --git.*\n\\|" diff-hunk-header-re "\\)")) But I don't know why diff-hunk-header-re doesn't match hunk headings in outline-minor-mode.