From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc. Date: Fri, 01 Apr 2022 19:35:38 +0300 Organization: LINKOV.NET Message-ID: <86pmm1azkd.fsf@mail.linkov.net> References: <87sftyweb2.fsf@gmail.com> <86k0f9xnrn.fsf@mail.linkov.net> <87tuedp6pl.fsf@gmail.com> <861r1g7n3b.fsf@mail.linkov.net> <87o84jcx5x.fsf@gmail.com> <8635lvif0r.fsf@mail.linkov.net> <87mtidip1w.fsf@gmail.com> <86zglrl4gq.fsf@mail.linkov.net> <87ee32yk7v.fsf@gmail.com> <861qz1zqfb.fsf@mail.linkov.net> <875yod1wyb.fsf@gmail.com> <86mtho5y56.fsf@mail.linkov.net> <87sfrgz979.fsf@gmail.com> <861qz0475w.fsf@mail.linkov.net> <87sfrd2cbb.fsf@gmail.com> <86fsnc4fvm.fsf@mail.linkov.net> <878rsz6um2.fsf@gmail.com> <86ils2mmbe.fsf@mail.linkov.net> <87v8w2qsee.fsf@gmail.com> <86y20vu9c6.fsf@mail.linkov.net> <875ynt41g9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32018"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 53126@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 01 18:45:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1naKOz-0008Av-Eo for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Apr 2022 18:45:33 +0200 Original-Received: from localhost ([::1]:50950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naKOx-0000l8-V0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Apr 2022 12:45:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naKOU-0000gM-Ru for bug-gnu-emacs@gnu.org; Fri, 01 Apr 2022 12:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naKOU-0004rK-J8 for bug-gnu-emacs@gnu.org; Fri, 01 Apr 2022 12:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1naKOU-0005XM-FM for bug-gnu-emacs@gnu.org; Fri, 01 Apr 2022 12:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Apr 2022 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53126-submit@debbugs.gnu.org id=B53126.164883144421179 (code B ref 53126); Fri, 01 Apr 2022 16:45:02 +0000 Original-Received: (at 53126) by debbugs.gnu.org; 1 Apr 2022 16:44:04 +0000 Original-Received: from localhost ([127.0.0.1]:43266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1naKNY-0005VX-An for submit@debbugs.gnu.org; Fri, 01 Apr 2022 12:44:04 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:40453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1naKNW-0005Ut-5U for 53126@debbugs.gnu.org; Fri, 01 Apr 2022 12:44:03 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 9E743FF805; Fri, 1 Apr 2022 16:43:54 +0000 (UTC) In-Reply-To: <875ynt41g9.fsf@gmail.com> (Augusto Stoffel's message of "Fri, 01 Apr 2022 11:06:46 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229232 Archived-At: >>> Lazy highlight is controlled by lots of variables. These variables need >>> to be set for the duration of the minibuffer session that reads the >>> replacement strings. If we move this to a separate function, we can't >>> use 'let' anymore, so we basically need to reinvent the dynamic scoping >>> feature of Elisp (i.e., save the current values, set the variables to >>> new values, then restore the old values in some hook). And an even ugly >>> workaround would be needed to replace the necessary condition-case. Or >>> do I misunderstand you altogether? >> >> Do you think a macro could help to make this function short again? > > That could be done, of course, but I'm pretty sure that this macro would > be used exactly once. I don't think we should have a general-purpose > macro to set up the lazy highlighting for arbitrary minibuffer commands, > because complex cases like query-replace will be rare, Why do you think query-replace is more complex than other minibuffer commands? Other minibuffer commands need to set all the same a dozen of variables that control lazy highlighting. Otherwise, they will highlight some random matches that happen to reuse values left from a previous isearch. > and in any case we can't anticipate all special requirements. To anticipate all requirements, I recommend to try adding this feature at least to occur. Then we will see what code needs to be shared. > Anyway, should I refactor my patch to use a macro? As long as experimentation will prove at least occur can use this macro. > Something else that could make 'query-replace-read-args' slightly > shorter is to define > > (defun replace-regexp-function (delimited-flag) > (or replace-regexp-function > delimited-flag > (and replace-char-fold > (not regexp-flag) > #'char-fold-to-regexp))) > > This function could be used in 3 different places in replace.el. This would be nice, maybe to be used as an optional argument of the macro. >> Then when you would want to add highlighting to the minibuffer >> reading the TO part of replacement too or to other minibuffers, >> it would be easy to just add a single line with that macro. > > Right, a preview of the replacement text will also need some extra work. > This will probably involve some extension to > 'isearch-lazy-highlight-update', making it even more complicated... Why? Shouldn't it just highlight the same way the text entered into the minibuffer that reads the replacement?