From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 10:22:24 +0300 Organization: LINKOV.NET Message-ID: <86pml1wu33.fsf@mail.linkov.net> References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> <87k0b9he68.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21122"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 55149@debbugs.gnu.org, monnier@iro.umontreal.ca, iarchivedmywholelife@gmail.com To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 09:45:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njypr-0005KF-C8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 09:45:11 +0200 Original-Received: from localhost ([::1]:37850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njypq-0001IE-DL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 03:45:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyWM-0002yG-Pw for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:25:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51249) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njyWM-0000ze-H3 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njyWM-00072R-De for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 07:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" , No Wayman , 55149@debbugs.gnu.org, Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.165113067327013 (code B ref -1); Thu, 28 Apr 2022 07:25:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Apr 2022 07:24:33 +0000 Original-Received: from localhost ([127.0.0.1]:45146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njyVt-00071d-4z for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:24:33 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:42734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njyVr-00071S-Qg for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:24:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyVa-0002OD-SY for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:24:25 -0400 Original-Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]:43677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyVZ-0000ti-2L for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:24:14 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 5A9D2100003; Thu, 28 Apr 2022 07:24:06 +0000 (UTC) In-Reply-To: <87k0b9he68.fsf@fastmail.fm> (Tassilo Horn's message of "Thu, 28 Apr 2022 09:12:27 +0200") Received-SPF: pass client-ip=2001:4b98:dc4:8::231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230842 Archived-At: >> The regression is that the return value of :after now overrides >> the return value of the original function. > > Oh, indeed. But isn't that exactly as documented for add-function? > > :after (lambda (&rest r) (apply OLDFUN r) (apply FUNCTION r)) Indeed, it seems documentation differed from the actual implementation. > Of course, we'd rather want > > :after (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r))) Yep, this looks like what it's natural to expect from such advice type. Or maybe a new type could be added to modify the return value?