From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#65805: 30.0.50; quoted-insert doesn't work in zap-to-char Date: Wed, 13 Sep 2023 19:39:32 +0300 Organization: LINKOV.NET Message-ID: <86pm2mtatn.fsf@mail.linkov.net> References: <834jk6yqbh.fsf@gnu.org> <86msxx3nw9.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37054"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , Filipp Gunbin , 65805@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 13 18:50:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgT49-0009SQ-1D for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Sep 2023 18:50:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgT3x-00086N-W3; Wed, 13 Sep 2023 12:50:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgT3t-00083K-5W for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 12:49:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgT3s-0002yW-UF for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 12:49:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgT3y-0002DO-7A for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 12:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Sep 2023 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65805 X-GNU-PR-Package: emacs Original-Received: via spool by 65805-submit@debbugs.gnu.org id=B65805.16946237668434 (code B ref 65805); Wed, 13 Sep 2023 16:50:02 +0000 Original-Received: (at 65805) by debbugs.gnu.org; 13 Sep 2023 16:49:26 +0000 Original-Received: from localhost ([127.0.0.1]:35809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgT3O-0002By-B5 for submit@debbugs.gnu.org; Wed, 13 Sep 2023 12:49:26 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:41157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgT3K-0002Bh-W9 for 65805@debbugs.gnu.org; Wed, 13 Sep 2023 12:49:24 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 54EED24000B; Wed, 13 Sep 2023 16:49:08 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Thu, 07 Sep 2023 13:48:31 -0400") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270336 Archived-At: >> I have a patch where exit-minibuffer in read-char-from-minibuffer-map >> is bound to a new command that ensures that the minibuffer contains >> exactly 1 character before exiting. But need more testing to see >> what is better. > > `read-char-from-minibuffer` usually doesn't require the user to use an > explicit key to exit (because it tries to mimic `read-char`). I don't remember how I got into a situation that required typing RET to exit the minibuffer. Probably pasted a character into the minibuffer with C-y. I see that your patch handles this now. @@ -3499,7 +3499,7 @@ read-char-from-minibuffer-map (let ((map (make-sparse-keymap))) (set-keymap-parent map minibuffer-local-map) - (define-key map [remap self-insert-command] #'read-char-from-minibuffer-insert-char) + ;; (define-key map [remap self-insert-command] #'read-char-from-minibuffer-insert-char) (define-key map [remap exit-minibuffer] #'read-char-from-minibuffer-insert-other) Maybe remapping exit-minibuffer is not needed anymore too? @@ -3530,7 +3530,7 @@ read-char-from-minibuffer-insert-other such key, this command discard all minibuffer input and displays an error message." (interactive) - (when (minibufferp) + (when (minibufferp) ;;FIXME: Why? Because of bug#45029. Maybe this bug number should be mentioned in the comments. @@ -3578,6 +3578,10 @@ read-char-from-minibuffer (interactive) (let ((help-form msg)) ; lexically bound msg (help-form-show))))) + ;; FIXME: We use `read-char-from-minibuffer-insert-char' + ;; here only as a kind of alias of `self-insert-command' + ;; to prevent those keys from being remapped to + ;; `read-char-from-minibuffer-insert-other'. (dolist (char chars) (define-key map (vector char) #'read-char-from-minibuffer-insert-char)) (define-key map [remap self-insert-command] #'read-char-from-minibuffer-insert-other) Interesting that [remap self-insert-command] is applied even to the commands explicitly bound to 'self-insert-command' in the same keymap. I see no way to override this. So 'read-char-from-minibuffer-insert-char' can't be replaced with 'self-insert-command'. @@ -3589,7 +3593,15 @@ read-char-from-minibuffer read-char-from-minibuffer-map)) ;; Protect this-command when called from pre-command-hook (bug#45029) (this-command this-command) - (result (progn + (result (minibuffer-with-setup-hook + (lambda () + (add-hook 'post-command-hook + (lambda () + ;; FIXME: Should we use `<='? + (if (= (1+ (minibuffer-prompt-end)) + (point-max)) + (exit-minibuffer))) + nil 'local)) I think we should use `<=' to handle the case when a string with more than 1 character is pasted with 'C-y'. This still requires some special-handling like I intended to do in a new command that exits the minibuffer where it should remove extra characters to leave only one: either the first or the last one. Perhaps leaving the first character makes more sense.