From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 33871@debbugs.gnu.org
Subject: bug#33871: 27.0.50; Revert Dired window saved in window configuration
Date: Sat, 23 Mar 2024 20:31:57 +0200 [thread overview]
Message-ID: <86plvksv1e.fsf@mail.linkov.net> (raw)
In-Reply-To: <5cf2b85e-9e24-4a7d-b175-ce140580df32@gmx.at> (martin rudalics's message of "Sat, 23 Mar 2024 10:14:25 +0100")
>> Ok, let's add new code to separate functions
>> 'window-set-context' and 'window-use-context'.
>> Below is the patch with these new functions.
>> Maybe they could be moved from tab-bar.el to window.el?
>
> I think you should do that.
OTOH, tab-bar.el is preloaded as well, so no problem to leave this
in tab-bar.el, since window.el is too large already.
> Maybe 'window-restore-set-context' and 'window-restore-use-context'
> would be more indicative names.
The name 'window-restore-set-context' looks quite self-contradictory.
If your intention was to use a unique prefix, then maybe we could use the
prefix 'window-context' like in 'window-context-set', 'window-context-use'.
> Note that when a buffer is killed, the values of its local variables may
> be lost. I don't know whether this is an issue here. Alternatively, we
> could have 'set_window_buffer' set the 'context' window parameter from
> the buffer-local value which would, however, mean that whenever one
> changes the buffer-local value, one would have to simultaneously update
> the parameters in all windows showing that buffer. Something that could
> be done with the help of an advice, though...
This doesn't look like an issue here because the context is stored
in a window parameter. And when the buffer is killed, there is no need
to restore a context in the killed buffer.
The format of the window parameter
'(BUFFER-NAME . ((dired-filename . FILENAME)))
uses BUFFER-NAME to check whether the buffer was killed,
and when the current window's buffer doesn't match BUFFER-NAME,
then do nothing.
next prev parent reply other threads:[~2024-03-23 18:31 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-25 21:39 bug#33871: 27.0.50; Revert Dired window saved in window configuration Juri Linkov
2018-12-26 9:43 ` martin rudalics
2018-12-27 0:01 ` Juri Linkov
2018-12-27 9:37 ` martin rudalics
2018-12-27 21:34 ` Juri Linkov
2018-12-28 8:34 ` martin rudalics
2018-12-29 11:19 ` Markus Triska
2018-12-29 18:18 ` martin rudalics
2018-12-29 23:21 ` Juri Linkov
2018-12-30 9:52 ` martin rudalics
2018-12-30 14:57 ` martin rudalics
2018-12-30 21:29 ` Juri Linkov
2022-02-12 8:45 ` Lars Ingebrigtsen
2022-02-13 18:40 ` Juri Linkov
2022-02-14 9:13 ` martin rudalics
2022-02-14 18:10 ` Juri Linkov
2022-02-14 18:36 ` martin rudalics
2022-02-15 19:30 ` Juri Linkov
2022-02-16 8:50 ` martin rudalics
2022-02-16 18:34 ` Juri Linkov
2022-02-17 10:05 ` martin rudalics
2022-02-17 17:28 ` Juri Linkov
2022-02-19 9:37 ` martin rudalics
2022-02-19 17:08 ` Juri Linkov
2022-02-19 17:22 ` martin rudalics
2022-02-20 18:40 ` Juri Linkov
2022-02-21 9:07 ` martin rudalics
2022-02-22 17:14 ` Juri Linkov
2022-02-23 9:31 ` martin rudalics
2022-02-23 17:53 ` Juri Linkov
2022-02-24 9:19 ` martin rudalics
2024-02-16 7:37 ` Juri Linkov
2024-02-16 9:41 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-18 7:39 ` Juri Linkov
2024-02-19 9:42 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-20 7:45 ` Juri Linkov
2024-02-21 9:05 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-21 17:18 ` Juri Linkov
2024-03-20 17:27 ` Juri Linkov
2024-03-21 9:20 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-21 17:54 ` Juri Linkov
2024-03-22 9:26 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-22 16:15 ` Juri Linkov
2024-03-23 9:14 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-23 18:31 ` Juri Linkov [this message]
2024-03-24 9:54 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-24 17:12 ` Juri Linkov
2024-03-25 9:41 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-25 17:10 ` Juri Linkov
2024-03-26 9:55 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 7:40 ` Juri Linkov
2024-03-28 9:18 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 17:54 ` Juri Linkov
2024-03-29 8:45 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 16:25 ` Juri Linkov
2024-03-30 9:36 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 18:19 ` Juri Linkov
2024-04-02 17:19 ` Juri Linkov
2024-04-09 6:44 ` Juri Linkov
2024-04-09 9:05 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plvksv1e.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=33871@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).