From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70573: 30.0.50; Setting gud-gud-lldb-command-name does not take effect Date: Fri, 26 Apr 2024 09:29:21 +0300 Message-ID: <86pluczlfi.fsf@gnu.org> References: <86ttjpz2p9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8558"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70573@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 26 08:30:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0F6F-00024u-0D for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Apr 2024 08:30:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0F5o-0004Rn-Sc; Fri, 26 Apr 2024 02:29:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0F5l-0004Ql-6m for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 02:29:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0F5j-000054-3j for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 02:29:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s0F60-0004NX-J6 for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 02:30:08 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Apr 2024 06:30:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70573 X-GNU-PR-Package: emacs Original-Received: via spool by 70573-submit@debbugs.gnu.org id=B70573.171411299416623 (code B ref 70573); Fri, 26 Apr 2024 06:30:07 +0000 Original-Received: (at 70573) by debbugs.gnu.org; 26 Apr 2024 06:29:54 +0000 Original-Received: from localhost ([127.0.0.1]:33639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0F5k-0004Jj-5i for submit@debbugs.gnu.org; Fri, 26 Apr 2024 02:29:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0F5h-0004Iv-Bv for 70573@debbugs.gnu.org; Fri, 26 Apr 2024 02:29:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0F5J-0008Us-M7; Fri, 26 Apr 2024 02:29:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=wll9WaFzbJUBRu/JEnRWYRfmMvfa6SSx0vm3W3/8kPA=; b=PrfY7nnxcE2unCFt+Gg1 ctxKEGcafIILvN+gGhPOCzQL268JLl+ob3Qtwl2BTEoBaqxEAwctoluhfniVluxQOzxfciYqq+ov0 C8tifgrqr+sfhIeNWdIwonJvi/u0mxFAmy1GgTOhWejK/YYn56qe6/eBY7eOp6WSDDiMDj7m5djpK 3awk3e92qjDN5nasR4sfr689xkiDTe3nkwTlRNx61gveWAEwgp72/Wu6lS3S5Z5IKtz7vPQ4sUHE8 XPZ0TYIbakUKcSQgs1AtB0fEp90uBPTGKN5Intc8IqVxZ1IHt8s9kvcEiFgVYPfCBfnuJn5ywuEbd l6Dc2lr8l42IaQ==; In-Reply-To: (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Thu, 25 Apr 2024 21:25:48 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283969 Archived-At: > From: Gerd Möllmann > Cc: 70573@debbugs.gnu.org > Date: Thu, 25 Apr 2024 21:25:48 +0200 > > Eli Zaretskii writes: > > > It looks like this part: > > > > (interactive (list (gud-query-cmdline 'lldb))) > > > > is the culprit: the minor-mode, which is the argument to > > gud-query-cmdline, should be 'gud-lldb, not 'lldb. Here's my > > evidence: > > > > (when (and gud-comint-buffer > > (buffer-name gud-comint-buffer) > > (get-buffer-process gud-comint-buffer) > > (with-current-buffer gud-comint-buffer (eq gud-minor-mode 'gud-lldb))) > > > > Btw, this line seems also to be confused wrt the name of > > gud-minor-mode: > > > > (setq-local gud-minor-mode 'lldb) > > I'm currently seriously confused by gud.el, I'm afraid. And I was > already confused when I tried to mimic gud-gdb here, which does > > (interactive (list (gud-query-cmdline 'gud-gdb))) > > (when (and gud-comint-buffer > (buffer-name gud-comint-buffer) > (get-buffer-process gud-comint-buffer) > (with-current-buffer gud-comint-buffer (eq gud-minor-mode 'gdbmi))) > (gdb-restore-windows) > (error > "Multiple debugging requires restarting in text command mode")) > > (gud-common-init command-line nil 'gud-gdb-marker-filter) > (setq-local gud-minor-mode 'gdb) I don't think the complications of GDB should concern you. AFAIU, the above tries to handle the tricky situation where we have 2 GDB minor modes: gdbmi and gud-gdb. There's no such problem with LLDB, AFAIU. So I think you should copy-cat the other minor modes, like gud-pdb, which don't have these complications. > Would you agree that the interactive form should use gud-lldb, but that > the setq-local is right? The setq-local is gud-gdb uses gdb, not > gud-gdb. Or am I confusing myself here? I think both should use gud-lldb, at least that's my understanding. Look at gud-query-cmdline, gud-val, and gud-symbol, and you will see that they encode the command name as gud-MINORMODE-SYMBOL, where SYMBOL is "command-name" in this case. So if the command name's symbol is gud-gud-lldb-command-name, then MINORMODE must be gud-lldb, for this stuff to work.