From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71176: 30.0.50; Segmentation fault (SIGSEGV) in TTY+emacsclient, default_face is nil Date: Sat, 25 May 2024 20:48:07 +0300 Message-ID: <86plt9ye94.fsf@gnu.org> References: <86r0dr106n.fsf@gnu.org> <867cfiyset.fsf@gnu.org> <86r0dpyfa8.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12891"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71176@debbugs.gnu.org To: n142857@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 25 19:49:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAvWF-000355-6H for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 May 2024 19:49:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAvVq-0007aU-FG; Sat, 25 May 2024 13:48:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAvVo-0007a6-4w for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 13:48:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAvVm-0004Nd-Mb for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 13:48:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAvVu-0005jx-9S for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 13:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 17:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71176 X-GNU-PR-Package: emacs Original-Received: via spool by 71176-submit@debbugs.gnu.org id=B71176.171665932122059 (code B ref 71176); Sat, 25 May 2024 17:49:02 +0000 Original-Received: (at 71176) by debbugs.gnu.org; 25 May 2024 17:48:41 +0000 Original-Received: from localhost ([127.0.0.1]:44767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAvVZ-0005jj-CL for submit@debbugs.gnu.org; Sat, 25 May 2024 13:48:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAvVX-0005jZ-Dl for 71176@debbugs.gnu.org; Sat, 25 May 2024 13:48:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAvVI-0004FG-Ha; Sat, 25 May 2024 13:48:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=96w92sT+PO6FHc1uINgUywM1xB5uxOVnNNeUnie12Ik=; b=AJLK+Nk2hWse m9sn2RmiEGR47KEAwFT1dd5RzUO2pDhEFEZApIi0ixrz5+xxx8qgqVJZmfEssDSh5SfJVdiqVqcMm K4nQoDBjychnLjIxLzYlpi/NPlQpoMQwFcfI97V7ArTTnV80M4jbJ++oGQwpou4sFF2upVY7J78Ob rkcfxRnuqdTkA3RSNQDYryYfNKX8XZ9n1r3NpSwkHrSFxCvIKj21tRpb5xiecg7AmRUkNl92hgO5M 9P0/x+H7zoGhtlpQODYNOEbuMiqEvYQXUFTxeBupSCaMZ+fZ8ZQ/qrBsf5kHJ+FYKWz9CxRg3/8/z NH8FeVFD9JBsWY7Nuq5/Qg==; In-Reply-To: <86r0dpyfa8.fsf@gnu.org> (message from Eli Zaretskii on Sat, 25 May 2024 20:25:51 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285902 Archived-At: > Cc: 71176@debbugs.gnu.org > Date: Sat, 25 May 2024 20:25:51 +0300 > From: Eli Zaretskii > > > From: Daniel Clemente > > Date: Sat, 25 May 2024 16:22:12 +0000 > > Cc: Eli Zaretskii > > > > With those changes (on top of the 2 weeks old commit I was using) it still fails in the same way. > > OK. Please show the output of the following GDB commands: > > (gdb) p f->face_cache->used > (gdb) p Vface_remapping_alist And also, please try the patch below. diff --git a/src/xfaces.c b/src/xfaces.c index 5192b22..4f7214e 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -4246,12 +4246,19 @@ DEFUN ("internal-merge-in-global-face", Finternal_merge_in_global_face, /* This can be NULL (e.g., in batch mode). */ if (oldface) { + /* In some cases, realize_face below can call Lisp, which could + trigger redisplay. But we are in the process of realizing + the default face, and therefore are not ready to do display. */ + specpdl_ref count = SPECPDL_INDEX (); + specbind (Qinhibit_redisplay, Qt); + /* Ensure that the face vector is fully specified by merging the previously-cached vector. */ memcpy (attrs, oldface->lface, sizeof attrs); merge_face_vectors (NULL, f, lvec, attrs, 0); vcopy (local_lface, 0, attrs, LFACE_VECTOR_SIZE); + newface = realize_face (c, lvec, DEFAULT_FACE_ID); if ((! UNSPECIFIEDP (gvec[LFACE_FAMILY_INDEX]) @@ -4291,6 +4298,8 @@ DEFUN ("internal-merge-in-global-face", Finternal_merge_in_global_face, gvec[LFACE_BACKGROUND_INDEX]); Fmodify_frame_parameters (frame, arg); } + + unbind_to (count, Qnil); } }