From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Date: Thu, 06 Jun 2024 09:12:10 +0300 Organization: LINKOV.NET Message-ID: <86plsuppl1.fsf@mail.linkov.net> References: <86ikymipzx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8254"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: martin rudalics , Al Haji-Ali , 71386@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 06 08:25:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sF6Yy-00021V-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jun 2024 08:25:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sF6YN-0000ty-MD; Thu, 06 Jun 2024 02:24:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF6YK-0000t0-EL for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 02:24:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sF6YK-0001Bi-6G for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 02:24:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sF6YY-00016e-Iy for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 02:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jun 2024 06:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71386 X-GNU-PR-Package: emacs Original-Received: via spool by 71386-submit@debbugs.gnu.org id=B71386.17176550814182 (code B ref 71386); Thu, 06 Jun 2024 06:25:02 +0000 Original-Received: (at 71386) by debbugs.gnu.org; 6 Jun 2024 06:24:41 +0000 Original-Received: from localhost ([127.0.0.1]:41736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF6YC-00015N-L1 for submit@debbugs.gnu.org; Thu, 06 Jun 2024 02:24:40 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:49089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF6YA-000157-QQ for 71386@debbugs.gnu.org; Thu, 06 Jun 2024 02:24:39 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id A592C60002; Thu, 6 Jun 2024 06:23:57 +0000 (UTC) In-Reply-To: <86ikymipzx.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Jun 2024 08:45:06 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286661 Archived-At: >> If I open a frame with multiple tabs, and one of the tabs has >> a dedicated window, then kill the buffer with the dedicated window, >> the frame is deleted along with its tabs. >> >> I understand that this is the documented behaviour, however my >> expectation is that the tab should be deleted but the frame should >> stay when other tabs are available, similar to how the frame is not >> deleted if other windows are visible. > > I'm not sure I agree with you. Tabs are just saved frame > configurations, they are not real windows. If we make this behavior > dependent on tab-bar-mode, we basically introduce an incompatible > behavior change in this particular case, which people and Lisp > programs out there might not expect or like. > > I'm adding Juri and Martin to this discussion. I don't understand the logic of window--delete. But maybe window-deletable-p should also check for existing tabs in tab-bar-mode and return 'tab' instead of 'frame'. Then window--delete could close the tab instead of deleting the frame.