From: Eli Zaretskii <eliz@gnu.org>
To: TOMAS FABRIZIO ORSI <torsi@fi.uba.ar>
Cc: pbreton@cs.umb.edu, stefankangas@gmail.com, 71438@debbugs.gnu.org
Subject: bug#71438: [PATCH] Allow ping to receive optional arguments
Date: Sun, 09 Jun 2024 18:21:13 +0300 [thread overview]
Message-ID: <86plsq9m6u.fsf@gnu.org> (raw)
In-Reply-To: <CAHTSwYg_5mNMLG9qnxhgLq1E2e0cKmF6XQcXoqrOMNFGSOAsCw@mail.gmail.com> (message from TOMAS FABRIZIO ORSI on Sun, 9 Jun 2024 12:03:37 -0300)
> From: TOMAS FABRIZIO ORSI <torsi@fi.uba.ar>
> Date: Sun, 9 Jun 2024 12:03:37 -0300
> Cc: pbreton@cs.umb.edu, 71438@debbugs.gnu.org
>
> Stefan Kangas said:
> > Consider adding a ChangeLog entry to the commit message, see CONTRIBUTE.
>
> Noted. I thought my patch was too small to be mentioned in ChangeLog.
> I'll keep this in mind for future patches :D.
> As a side note, I found the CONTRIBUTE file very helpful.
> I personally found
> https://www.gnu.org/software/emacs/manual/html_node/emacs/Contributing.html
> to be a bit unclear.
I suggest instead to read the file CONTRIBUTE in the top-level
directory of the Emacs source tree.
> Eli Zaretskii said:
> > Yes, I think we should do that, in which case the change is no longer
> backward-incompatible.
>
> Great! What's the procedure now? Should I upload a new patch to this
> same thread with the changes you both mentioned?
Yes, please .
> As a side note, any additional notes?
> Any style comments?
Just one: try to keep lines shorter than 80 columns, and break longer
lines into several ones.
> Elisp advice? Any other function I should look into
> to "imitate" the style of a good use of prefix argument?
Any command that uses the fact of being invoked with a prefix argument
to modify its behavior will do.
next prev parent reply other threads:[~2024-06-09 15:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 15:28 bug#71438: [PATCH] Allow ping to receive optional arguments TOMAS FABRIZIO ORSI
2024-06-08 18:48 ` Peter Breton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 18:57 ` TOMAS FABRIZIO ORSI
2024-06-09 12:02 ` Stefan Kangas
2024-06-09 13:47 ` Eli Zaretskii
2024-06-09 15:03 ` TOMAS FABRIZIO ORSI
2024-06-09 15:21 ` Eli Zaretskii [this message]
2024-06-09 15:38 ` Stefan Kangas
2024-06-09 15:48 ` TOMAS FABRIZIO ORSI
2024-06-16 21:46 ` TOMAS FABRIZIO ORSI
2024-06-17 1:14 ` Stefan Kangas
2024-06-17 2:03 ` TOMAS FABRIZIO ORSI
2024-06-17 6:19 ` Stefan Kangas
2024-06-19 2:17 ` TOMAS FABRIZIO ORSI
2024-06-20 18:45 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plsq9m6u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71438@debbugs.gnu.org \
--cc=pbreton@cs.umb.edu \
--cc=stefankangas@gmail.com \
--cc=torsi@fi.uba.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).