From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71469: [PATCH] Re: bug#71469: font-lock does not apply standard faces and their descendants Date: Mon, 10 Jun 2024 18:17:02 +0300 Message-ID: <86plso96a9.fsf@gnu.org> References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13005"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71469@debbugs.gnu.org To: Konstantin Kharlamov , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 10 17:18:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGgmf-00036R-FM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Jun 2024 17:18:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGgmK-0001wK-Qw; Mon, 10 Jun 2024 11:17:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGgmJ-0001vO-2Z for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2024 11:17:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGgmI-0000AO-K5 for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2024 11:17:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGgmY-0006jP-5K for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2024 11:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jun 2024 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71469 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 71469-submit@debbugs.gnu.org id=B71469.171803265325787 (code B ref 71469); Mon, 10 Jun 2024 15:18:02 +0000 Original-Received: (at 71469) by debbugs.gnu.org; 10 Jun 2024 15:17:33 +0000 Original-Received: from localhost ([127.0.0.1]:41172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGgm4-0006hm-KD for submit@debbugs.gnu.org; Mon, 10 Jun 2024 11:17:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGgm1-0006hI-VO for 71469@debbugs.gnu.org; Mon, 10 Jun 2024 11:17:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGgld-00004s-Qt; Mon, 10 Jun 2024 11:17:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qe3mlNImGy78fMuTmGvCtl/kgnZ7F7l+chEMiumRjns=; b=PJq7jmlqljYL VhgBnkrB3JWIvCUfKes/k33HeEt87YYHwQ0/026ymJjdv0krcc1Za8+jiHW03BlC44x3XCydozx4V BIZsi2yTBOR7KMfjRLewaqAEUQjLOQbcxUcicNgonSvZKjqVkrUqSmCUrv2yKiL/M7SYzDguZoAbU p6ynvHE4TzF50ekUJefkr0qO7rvyouYycUaRqjTx0RGBBSTfwqCtNb0qj7CYgl7q7HQK1LqVy23YZ 35pc47gdiewhagzmjjReJXcB6vdcHauuLEfWlOxBRxLVM2ZkCP/Y277Y26idO4QSRwvTdjKVnsq/v QwIGuUgq+AXo982YdwFscA==; In-Reply-To: <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> (message from Konstantin Kharlamov on Mon, 10 Jun 2024 16:41:53 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287042 Archived-At: > From: Konstantin Kharlamov > Cc: 71469@debbugs.gnu.org > Date: Mon, 10 Jun 2024 16:41:53 +0300 > > I'm wondering if it would be okay to mention such nuance in the > "standard faces" documentation, such as with the attached patch? I > think it would be really helpful, because the nuance of how it works is > not obvious at all (it would be much easier if none of the faces such > as font-lock-keyword-face, would be defining a variable). I've spent > for about an hour on this trying in different ways to make it work, and > I also think it wasn't the first time I stumbled upon this. Having the > "standard faces" mention that interaction nuance I think could be > helpful for people in the future. > > > From 02811b6400259c0d9b2dedcca76fec771dcd839a Mon Sep 17 00:00:00 2001 > From: Konstantin Kharlamov > Date: Mon, 10 Jun 2024 16:34:30 +0300 > Subject: [PATCH] Mention interaction of standard faces with font-lock-keywords > > * doc/emacs/display.texi (standard faces): mention that these faces do > not produce variables and so can't be passed to font-lock-keywords as > is. > --- > doc/emacs/display.texi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/doc/emacs/display.texi b/doc/emacs/display.texi > index 8f22e3c88da..bcbe68d21ea 100644 > --- a/doc/emacs/display.texi > +++ b/doc/emacs/display.texi > @@ -647,7 +647,9 @@ Standard Faces > @cindex standard faces > > Here are the standard faces for specifying text appearance. You can > -apply them to specific text when you want the effects they produce. > +apply them to specific text when you want the effects they produce. Note > +that these faces do not define variables, so to pass such face to > +@code{font-lock-keywords} you have to quote it. I don't think I agree with this addition, so I added Stefan to this discussion. Stefan, any comments?