From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71655: Eshell external commands do not work under GNU Emacs for Windows Date: Sun, 23 Jun 2024 07:36:32 +0300 Message-ID: <86pls8ff73.fsf@gnu.org> References: <86y170oifx.fsf@gnu.org> <86v824ohym.fsf@gnu.org> <86r0csnrk7.fsf@gnu.org> <8b97b729-c431-1dc2-d4d4-b988120e7de0@gmail.com> <86cyocnjkl.fsf@gnu.org> <858d2907-7ee4-da6f-cd9e-6b7bd3ba4c7e@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38098"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71655@debbugs.gnu.org, james@literate-devops.io To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 23 06:39:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLF0Y-0009cO-Dc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jun 2024 06:39:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLF0L-00032r-49; Sun, 23 Jun 2024 00:39:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLF0I-00032T-NM for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 00:39:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLF0I-0004yc-FL for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 00:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLF0I-0004mU-FX for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 00:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2024 04:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71655 X-GNU-PR-Package: emacs Original-Received: via spool by 71655-submit@debbugs.gnu.org id=B71655.171911753118349 (code B ref 71655); Sun, 23 Jun 2024 04:39:02 +0000 Original-Received: (at 71655) by debbugs.gnu.org; 23 Jun 2024 04:38:51 +0000 Original-Received: from localhost ([127.0.0.1]:43850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLF07-0004lq-1H for submit@debbugs.gnu.org; Sun, 23 Jun 2024 00:38:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLF05-0004la-QC for 71655@debbugs.gnu.org; Sun, 23 Jun 2024 00:38:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLExt-0003w2-RO; Sun, 23 Jun 2024 00:36:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=H0yA4HE7CYxvQ8npuBEhuw+8jH2r4J+EPNnPrY7tuvg=; b=sXgs8Yg9AF6b Y/zcPS6NPCahQF2StQYFS1zURiZQY0MEa5j6gseOU+myOZzuuie1mh3IffMTxkSsCdjpCHNDJ5YDt CVIZpT2P4au3av2P+t4gP6WPkVD8Tcsm1BlbaEYhd3ZcDONcrMA/kL7LldupZqwH3QiNiUtKvgrNZ +mhWGUnboEuCuMgAzBl/+JEc1GwrN64p9egGUBVHcDJCZwz6lrmbAlkpZk5IDRHljq067CpHw1Aa3 hcn7PqYyFsKXyTc+G/4NZsl8ULpLaifDl2di+lZhqQXRhY7PezhZWChh6sxY8I9xM9JMkxEt2+GKr RJrYhkKDl4keUMtlg8IXzw==; In-Reply-To: <858d2907-7ee4-da6f-cd9e-6b7bd3ba4c7e@gmail.com> (message from Jim Porter on Sat, 22 Jun 2024 12:55:32 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287755 Archived-At: > Date: Sat, 22 Jun 2024 12:55:32 -0700 > Cc: 71655@debbugs.gnu.org, james@literate-devops.io > From: Jim Porter > > > I agree that all those other conditions (including the .exe test) seem > > to be reasonable, in addition to zero-size. > > Do you have a preference between either of these patches? They either > check for zero-size or ignore file errors when trying to insert. > > I don't have a strong preference myself, but the latter seems > ever-so-slightly safer to me. This bug happened because we can't read > the file when trying to insert it, so ignoring file errors would cover > any other situations we haven't predicted. On the other hand, maybe > there's a case where we *want* the 'insert-file-contents-literally' > error to signal so that we don't try to execute the file normally (I > can't think of any such cases, though). Why not do both? If the file has zero size, reading it is pointless, and if reading it signals an error, we cannot examine it for the interpreter signature. Thanks.