From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71720: [PATCH] Do not prematurely truncate python eldoc string Date: Thu, 27 Jun 2024 11:56:31 +0300 Message-ID: <86pls269xc.fsf@gnu.org> References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> <86ed8pgenb.fsf@gnu.org> <86msncvg0r.fsf@gmx.net> <86bk3s9xac.fsf@gmx.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21930"; mail-complaints-to="usenet@ciao.gmane.io" Cc: kobarity@gmail.com, 71720-done@debbugs.gnu.org To: James Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 10:57:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMkwW-0005Wi-Oe for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 10:57:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMkwA-0000qO-Op; Thu, 27 Jun 2024 04:57:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMkw7-0000ps-I4 for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 04:57:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMkw7-0008N4-9w for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 04:56:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMkw9-00085l-Sy for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 04:57:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 08:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 71720@debbugs.gnu.org, eliz@gnu.org, jimjoe@gmx.net Original-Received: via spool by 71720-done@debbugs.gnu.org id=D71720.171947860631081 (code D ref 71720); Thu, 27 Jun 2024 08:57:01 +0000 Original-Received: (at 71720-done) by debbugs.gnu.org; 27 Jun 2024 08:56:46 +0000 Original-Received: from localhost ([127.0.0.1]:40966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkvt-00085F-Qb for submit@debbugs.gnu.org; Thu, 27 Jun 2024 04:56:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkvr-000852-WE for 71720-done@debbugs.gnu.org; Thu, 27 Jun 2024 04:56:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMkvj-0008Ku-MB; Thu, 27 Jun 2024 04:56:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Bk1gg5FQBBPfDf82BCr4twhY5YykP1/ZiLMfeShbL5Q=; b=DgRItRe0ZVzm HosOAoP00pQXF3FT2vgtFcyt62nEK3RHeaXCjKG3knNoqjaCrlgV3ccEMzWrQMo7shmLZbHPemmwI aR4YvxbQ6AhBjv0T/pfSqt1FsXYXuXevh+sEx30PN8ydl1gvEiV36D+6iwxYmL64NExB7MZusqMPg /ordi74aYsrC4x7OIMTt2unW1XWe5xgFJEpagvOfrUGP4eDcL+tSTCoWIoocSZ+6jsByzLbz7Aq5y XMqKkq8U8aSdD/K3Ib/KwVwiJbf6opWY5o11jj4m0B81h6YGAfTc6gQpaE6/HR/SV3vBdzC873yyE 0sGh3G5ME64Rvgyb5jNicw==; In-Reply-To: <86bk3s9xac.fsf@gmx.net> (message from James Thomas on Sun, 23 Jun 2024 08:32:19 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287999 Archived-At: > From: James Thomas > Cc: Eli Zaretskii , 71720@debbugs.gnu.org > Date: Sun, 23 Jun 2024 08:32:19 +0530 > > kobarity wrote: > > > James Thomas wrote: > >> Eli Zaretskii wrote: > >> > >> >> Date: Sat, 22 Jun 2024 23:16:51 +0900 > >> >> From: kobarity > >> >> Cc: 71720@debbugs.gnu.org > >> >> > >> >> Eli Zaretskii wrote: > >> >> > > >> >> > kobarity, any comments? > >> >> > >> >> I agree with this fix. For those who want the same behavior as > >> >> before, setting eldoc-echo-area-use-multiline-p to nil should be > >> >> sufficient. It might be better to make this change known in etc/NEWS, > >> >> though. > >> > > >> > Thanks. > >> > > >> > James, can you add a NEWS entry and resubmit? > >> > >> How about this? > > > >> +*** 'eldoc' no longer truncates to a single line by default. > >> +Previously, the entire docstring was not available to eldoc, which made > >> +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be > >> +kept by setting that. > >> + > > > > Thanks, I think the content is perfect, but from other examples, it > > might be better to have two spaces after the period. > > Fixed: Thanks, installed on the emacs-30 branch, and closing the bug.