From: Eli Zaretskii <eliz@gnu.org>
To: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
Cc: billy.hotwind@gmail.com, 71500-done@debbugs.gnu.org
Subject: bug#71500: 28.2; Can't create/open .gpg file name contains non-ascii encoding in windows
Date: Sat, 29 Jun 2024 15:55:38 +0300 [thread overview]
Message-ID: <86plrzj4c5.fsf@gnu.org> (raw)
In-Reply-To: <85sewvylbp.wl--xmue@d1.dion.ne.jp> (message from Kazuhiro Ito on Sat, 29 Jun 2024 21:39:38 +0900)
> Date: Sat, 29 Jun 2024 21:39:38 +0900
> From: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
> Cc: 71500@debbugs.gnu.org,
> billy.hotwind@gmail.com
>
> > > As Tatsuya wrote, epg--start function calls gpg2 program with setting
> > > :coding property to raw-text, thus each argument should be encoded in
> > > proper coding system by a caller. The problem would occur on any OS
> > > whose file name coding system was not utf-8.
> > >
> > > For example, in case of epg-decrypt-file, following change is required
> > > if we need to set :coding property to raw-text for ENCODING.
> > >
> > > diff --git a/lisp/epg.el b/lisp/epg.el
> > > index 7bec91f616d..59870761565 100644
> > > --- a/lisp/epg.el
> > > +++ b/lisp/epg.el
> > > @@ -1468,7 +1468,10 @@ epg-decrypt-file
> > > (progn
> > > (setf (epg-context-output-file context)
> > > (or plain (make-temp-file "epg-output")))
> > > - (epg-start-decrypt context (epg-make-data-from-file cipher))
> > > + (epg-start-decrypt context
> > > + (epg-make-data-from-file
> > > + (encode-coding-string
> > > + cipher file-name-coding-system)))
> > > (epg-wait-for-completion context)
> > > (epg--check-error-for-decrypt context)
> > > (unless plain
> >
> > Thanks, but this doesn't look right to me. The problem is likely in
> > the fact that epg--start sets the encoding/decoding for the epg
> > process to raw-text in a way that is too broad: it affects not only
> > how we encode and decode text sent to and received from GnuPG, but
> > also how its command-line arguments are encoded. And that's not what
> > we want.
> >
> > So I think the right fix is in epg--start: instead of setting :coding
> > as part of the make-process call, it should call
> > set-process-coding-system _after_ the make-process call, so that
> > raw-text will affect only the text we send and receive from gpg.
> >
> > Can you try such a change and see if it fixes the problem?
>
> I tested attached patch and confirmed the issue was resolved.
Thanks, installed on the emacs-30 release branch, and closing the bug.
> I'm not sure that :coding setting for decoding in make-process can
> be removed. I mean, I don't know whether Emacs can receive output
> from process between make-process and set-process-coding-system.
Emacs is a single-threaded program, so until epg--start returns, no
output can be received and decoded by Emacs from the gpg sub-process.
So this is safe.
prev parent reply other threads:[~2024-06-29 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 13:35 bug#71500: 28.2; Can't create/open .gpg file name contains non-ascii encoding in windows Tatsuya Kumazawa
2024-06-12 7:52 ` Eli Zaretskii
2024-06-27 7:30 ` Eli Zaretskii
2024-06-28 11:30 ` Kazuhiro Ito
2024-06-29 11:25 ` Eli Zaretskii
2024-06-29 12:39 ` Kazuhiro Ito
2024-06-29 12:55 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plrzj4c5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71500-done@debbugs.gnu.org \
--cc=billy.hotwind@gmail.com \
--cc=kzhr@d1.dion.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).