From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Date: Thu, 11 Jul 2024 07:34:16 +0300 Message-ID: <86plrkmtrr.fsf@gnu.org> References: <86frsho5u2.fsf@gnu.org> <6a233903-b1df-3d8b-1c25-e6b4b40b4cd5@gmail.com> <86y169m9q6.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25834"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72018@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 11 06:37:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRlYe-0006Vq-7V for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jul 2024 06:37:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRlYO-0006pl-6q; Thu, 11 Jul 2024 00:37:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRlYH-0006pA-41 for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 00:37:08 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRlYE-0001KS-Pl for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 00:37:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRlYE-0004Gu-6I for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 00:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2024 04:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72018-submit@debbugs.gnu.org id=B72018.172067259616380 (code B ref 72018); Thu, 11 Jul 2024 04:37:02 +0000 Original-Received: (at 72018) by debbugs.gnu.org; 11 Jul 2024 04:36:36 +0000 Original-Received: from localhost ([127.0.0.1]:50659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRlXn-0004G8-U4 for submit@debbugs.gnu.org; Thu, 11 Jul 2024 00:36:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRlXl-0004Fv-Se for 72018@debbugs.gnu.org; Thu, 11 Jul 2024 00:36:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRlVb-0005ps-Os; Thu, 11 Jul 2024 00:34:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yIipisYpKoVo9Z7Y6ubd7r+ad1/F508LsCddhV9l8oE=; b=l2I66ae/gIBy GjMA+j1UOOuweg8jjhtXNM7VEItS6iOZBJQbiAdf/Jkgim5oWqKPtyvL8gpsQ1ooyHsguRkWiELAW 63Drs6P3plj6IS4lfDmzixj6WXtEEhgAOcshF9mOCVTuRbF+4r0m4WSMRGh9DA2fN/c0lwMN7afXh 8opNtz7V38MFDKAiAD756YpskHiafHBix0uhTHKQDcM+RMm+UV/wYGxM5rv6ruwfQv+uzUg/3lvtk R4nDgx480wHJepNEIFSKqS+ggmMRJyjEHI6+TA+9ihY5GQwQkZU8USjG794zDc3Sn7/LCD7O0Z+6P Mxc91SwnKQk3vABkDmwaIQ==; In-Reply-To: (message from Jim Porter on Wed, 10 Jul 2024 12:55:25 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288709 Archived-At: > Date: Wed, 10 Jul 2024 12:55:25 -0700 > Cc: 72018@debbugs.gnu.org > From: Jim Porter > > On 7/10/2024 10:34 AM, Eli Zaretskii wrote: > >> Date: Wed, 10 Jul 2024 09:16:11 -0700 > >> Cc: 72018@debbugs.gnu.org > >> From: Jim Porter > >> > >> We want to reset the prompt (this just emits a new command prompt) for > >> foreground commands, but for background commands, we don't need to do > >> anything. Would it be clearer if I inverted the wording in the comment, > >> like, "Don't reset the prompt if the command we just aborted was in the > >> background"? > > > > I think these subtleties just warrant more detailed comments, and then > > we'll be fine. > > How about this? LGTM, thanks. This is okay for emacs-30.