From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72420: set-goal-column misbehaves with a line-prefix and visual-line-mode Date: Sat, 07 Sep 2024 10:16:54 +0300 Message-ID: <86plpgyluh.fsf@gnu.org> References: <86cym3wff7.fsf@gnu.org> <86le0osk43.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32368"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72420-done@debbugs.gnu.org To: meedstrom@runbox.eu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 07 09:18:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smpi6-0008Ia-Hz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Sep 2024 09:18:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smphv-0007Ir-6U; Sat, 07 Sep 2024 03:18:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smphr-0007IP-1i for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 03:18:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smphp-00053T-LJ for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 03:18:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=tyKiuG/CRgXJRnlVJNWpawghQ9fvSn30CR0kgy5V1/g=; b=pnG3TuHIYmSdIr4TbUA52CaV1V2RIcVSbFs+1Y0kND/jhHDmE+a+gvlATGG+uzWUvUM4Yi+ChKaw75jVk5RvO/+cPf/MAJIk8a6xZVt+tstsQxQ7jOkytR6dsxh3ZhsoIWXyEXqeq5Ov8KshCsujkT0s69sBNPcm/4JabHv/IKpGqA3R0HyEnY8YmqURG+8pA6Q7V2ylSBjyZbl//qnYimbra1le2ZfZrhvGDWEeUF4UYDYVVOmjHngfeHgSzuBy3N5CxyC1ebGTjCkb1cSREJpIB//4pdf90Vffj8g27qTxNGWDXOocZo3hIbHTV7AbQ80X2e6Y0+Oeoy4dUV1kjg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smphq-0000Jj-1y for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 03:18:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Sep 2024 07:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72420 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Mail-Followup-To: 72420@debbugs.gnu.org, eliz@gnu.org, meedstrom@runbox.eu Original-Received: via spool by 72420-done@debbugs.gnu.org id=D72420.17256934301139 (code D ref 72420); Sat, 07 Sep 2024 07:18:01 +0000 Original-Received: (at 72420-done) by debbugs.gnu.org; 7 Sep 2024 07:17:10 +0000 Original-Received: from localhost ([127.0.0.1]:54633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smph0-0000II-Fj for submit@debbugs.gnu.org; Sat, 07 Sep 2024 03:17:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smpgy-0000I5-2h for 72420-done@debbugs.gnu.org; Sat, 07 Sep 2024 03:17:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smpgr-0004yF-M4; Sat, 07 Sep 2024 03:17:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tyKiuG/CRgXJRnlVJNWpawghQ9fvSn30CR0kgy5V1/g=; b=pfnZnEI+NS5dv0ECFJAH 0cvUryshMvBFAjxkYMudSYJxCgVP34sdVCBHg4CFpaMhHtqzMnljTqRejCWOwOVS4AgZWEmlfXNAL EyIr7/+YiJm0KGhM86D9dpbfCz5lYgySzWa3TI7tW30Xn/HF/j5NVMJ4DYe57/Mei3u93fvSg0KR8 b4waJR8UivmEMzYS5UZuEIEmQKcx3DHjXu8gBROFWoWs2KGZyAg3MWBWvVjIL/XXvxdn3w0KegtKI SvuqD+MLo9Ajbc85RLWLjjRHB+cusWtqBtqetIZyqVKN0zA7qtP62HFNFYc0vhjSyetiU/6CrjCBs gPlfc1QS2SFILw==; In-Reply-To: <86le0osk43.fsf@gnu.org> (message from Eli Zaretskii on Thu, 22 Aug 2024 17:33:16 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291348 Archived-At: > Cc: 72420@debbugs.gnu.org > Date: Thu, 22 Aug 2024 17:33:16 +0300 > From: Eli Zaretskii > > > Cc: 72420@debbugs.gnu.org > > Date: Tue, 20 Aug 2024 15:24:12 +0300 > > From: Eli Zaretskii > > > > > From: "Martin Edström" > > > Date: Tue, 20 Aug 2024 10:28:44 +0200 (CEST) > > > > > > Can we undo the "notabug" tag on this one? The bug is with visual-line-mode. > > > > I didn't yet have time to take another look at this, sorry. When I > > do, I will consider this aspect. > > I've now made this test case behave the same both with and without > visual-line-mode on the master branch of the Emacs Git repository. > The patch is below (you will need to rebuild Emacs for it to be > effective, since simple.el is preloaded). > > diff --git a/lisp/simple.el b/lisp/simple.el > index a9f8b58..1d3be2b 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -8200,7 +8200,7 @@ line-move-finish > > ;; Move to the desired column. > (if (and line-move-visual > - (not (or truncate-lines truncate-partial-width-windows))) > + (not (or truncate-lines (truncated-partial-width-window-p)))) > ;; Under line-move-visual, goal-column should be > ;; interpreted in units of the frame's canonical character > ;; width, which is exactly what vertical-motion does. > No further comments, so I assume the bug is indeed fixed, and I'm closing this bug.