unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: meedstrom@runbox.eu
Cc: 72420-done@debbugs.gnu.org
Subject: bug#72420: set-goal-column misbehaves with a line-prefix and visual-line-mode
Date: Sat, 07 Sep 2024 10:16:54 +0300	[thread overview]
Message-ID: <86plpgyluh.fsf@gnu.org> (raw)
In-Reply-To: <86le0osk43.fsf@gnu.org> (message from Eli Zaretskii on Thu, 22 Aug 2024 17:33:16 +0300)

> Cc: 72420@debbugs.gnu.org
> Date: Thu, 22 Aug 2024 17:33:16 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Cc: 72420@debbugs.gnu.org
> > Date: Tue, 20 Aug 2024 15:24:12 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > 
> > > From: "Martin Edström" <meedstrom@runbox.eu>
> > > Date: Tue, 20 Aug 2024 10:28:44 +0200 (CEST)
> > > 
> > > Can we undo the "notabug" tag on this one?  The bug is with visual-line-mode.
> > 
> > I didn't yet have time to take another look at this, sorry.  When I
> > do, I will consider this aspect.
> 
> I've now made this test case behave the same both with and without
> visual-line-mode on the master branch of the Emacs Git repository.
> The patch is below (you will need to rebuild Emacs for it to be
> effective, since simple.el is preloaded).
> 
> diff --git a/lisp/simple.el b/lisp/simple.el
> index a9f8b58..1d3be2b 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -8200,7 +8200,7 @@ line-move-finish
>  
>  	;; Move to the desired column.
>          (if (and line-move-visual
> -                 (not (or truncate-lines truncate-partial-width-windows)))
> +                 (not (or truncate-lines (truncated-partial-width-window-p))))
>              ;; Under line-move-visual, goal-column should be
>              ;; interpreted in units of the frame's canonical character
>              ;; width, which is exactly what vertical-motion does.
> 

No further comments, so I assume the bug is indeed fixed, and I'm
closing this bug.





      reply	other threads:[~2024-09-07  7:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 10:35 bug#72420: set-goal-column misbehaves with a line-prefix and visual-line-mode Martin Edström
2024-08-04  8:47 ` Eli Zaretskii
2024-08-06 14:10   ` Martin Edstrom
2024-08-07 11:01     ` Eli Zaretskii
2024-08-07 12:07       ` Martin Edstrom
2024-08-07 12:19         ` Eli Zaretskii
2024-08-07 14:03           ` Martin Edstrom
2024-08-07 14:29             ` Eli Zaretskii
2024-08-07 14:53               ` Martin Edstrom
2024-08-06 14:24 ` Martin Edstrom
2024-08-07 11:04   ` Eli Zaretskii
2024-08-20  8:28 ` Martin Edström
2024-08-20 12:24   ` Eli Zaretskii
2024-08-22 14:33     ` Eli Zaretskii
2024-09-07  7:16       ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86plpgyluh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=72420-done@debbugs.gnu.org \
    --cc=meedstrom@runbox.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).