unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 69097@debbugs.gnu.org
Subject: bug#69097: [PATCH] Add 'kill-region-or-word' command
Date: Wed, 18 Sep 2024 19:08:35 +0300	[thread overview]
Message-ID: <86plp1osfw.fsf@mail.linkov.net> (raw)
In-Reply-To: <86v7yuupqo.fsf@mail.linkov.net> (Juri Linkov's message of "Tue,  17 Sep 2024 20:58:07 +0300")

> Thanks for the new command!

Sorry, I meant the new option.

> I'd like to use it, but currently can't
> because I have customized 'mark-even-if-inactive' to nil.

This small fix addresses the remaining issues:

diff --git a/lisp/simple.el b/lisp/simple.el
index 9fbd9bfb577..40266f37209 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -5865,7 +5865,7 @@ kill-region
   ;; Pass mark first, then point, because the order matters when
   ;; calling `kill-append'.
   (interactive (progn
-                 (let ((beg (mark))
+                 (let ((beg (mark kill-region-dwim))
                        (end (point)))
                    (cond
                     ((and kill-region-dwim (not (use-region-p)))
@@ -5888,10 +5888,12 @@ kill-region
                      ((filter-buffer-substring beg end 'delete)))))
 	(when string			;STRING is nil if BEG = END
 	  ;; Add that string to the kill ring, one way or another.
-	  (if (eq last-command 'kill-region)
+	  (if (and (null kill-region-dwim)
+		   (eq last-command 'kill-region))
 	      (kill-append string (< end beg))
 	    (kill-new string)))
-	(when (or string (eq last-command 'kill-region))
+	(when (and (null kill-region-dwim)
+		   (or string (eq last-command 'kill-region)))
 	  (setq this-command 'kill-region))
 	(setq deactivate-mark t)
 	nil)





  reply	other threads:[~2024-09-18 16:08 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-13  9:55 bug#69097: [PATCH] Add 'kill-region-or-word' command Philip Kaludercic
2024-02-17  3:53 ` Richard Stallman
     [not found]   ` <87ttm7gi9i.fsf@posteo.net>
2024-02-19  3:44     ` Richard Stallman
     [not found]       ` <87sf1obkw9.fsf@posteo.net>
2024-02-23  3:04         ` Richard Stallman
     [not found]           ` <871q93rzv8.fsf@posteo.net>
2024-02-25  3:16             ` Richard Stallman
     [not found]               ` <87frxgn73g.fsf@posteo.net>
2024-02-27  3:12                 ` Richard Stallman
2024-05-03  7:37 ` Philip Kaludercic
2024-05-03 10:40   ` Eli Zaretskii
2024-05-03 10:48     ` Philip Kaludercic
2024-05-03 10:59       ` Eli Zaretskii
2024-05-03 11:04         ` Eli Zaretskii
2024-05-03 17:32           ` Philip Kaludercic
2024-05-03 18:01             ` Eli Zaretskii
2024-05-03 19:41               ` Philip Kaludercic
2024-05-04  6:20                 ` Eli Zaretskii
2024-05-05  6:53                 ` Juri Linkov
2024-05-05  9:04                   ` Eli Zaretskii
2024-05-05 16:29                     ` Juri Linkov
2024-05-05 16:54                       ` Philip Kaludercic
2024-05-05 16:59                         ` Juri Linkov
2024-05-05 17:08                           ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-05 18:27                           ` Philip Kaludercic
2024-05-05 17:05                         ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-05 17:13                           ` Eli Zaretskii
2024-05-05 17:53                             ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-06  0:21                       ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-06 16:46                     ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-06 16:51                       ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-06 17:55                         ` Eli Zaretskii
2024-05-07  8:47                           ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-07  8:47                             ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-01 20:06                           ` Philip Kaludercic
2024-09-02  6:36                             ` Sean Whitton
2024-09-02 11:18                             ` Eli Zaretskii
2024-09-02 18:30                               ` Stefan Kangas
2024-09-02 18:45                                 ` Sean Whitton
2024-09-02 20:39                               ` Philip Kaludercic
2024-09-02 20:42                                 ` Sean Whitton
2024-09-02 20:45                                   ` Philip Kaludercic
2024-09-02 20:46                                   ` Sean Whitton
2024-09-02 21:12                                     ` Philip Kaludercic
2024-09-03 12:21                                       ` Eli Zaretskii
2024-09-03 13:53                                         ` Robert Pluim
2024-09-03 14:27                                           ` Eli Zaretskii
2024-09-03 14:55                                             ` Robert Pluim
2024-09-03 15:32                                               ` Eli Zaretskii
2024-09-03 16:32                                         ` Philip Kaludercic
2024-09-03 16:47                                           ` Robert Pluim
2024-09-04 11:08                                           ` Eli Zaretskii
2024-09-04 14:07                                           ` Sean Whitton
2024-09-04 14:21                                             ` Eli Zaretskii
2024-09-05  9:39                                             ` Philip Kaludercic
2024-09-05  9:52                                               ` Eli Zaretskii
2024-09-05 10:02                                                 ` Philip Kaludercic
2024-09-05 10:19                                                   ` Eli Zaretskii
2024-09-05 10:23                                                     ` Philip Kaludercic
2024-09-05 13:27                                               ` Sean Whitton
2024-09-05 14:38                                                 ` Philip Kaludercic
2024-09-06 10:36                                                   ` Sean Whitton
2024-09-06 11:06                                                     ` Sean Whitton
2024-09-06 11:30                                                     ` Eli Zaretskii
2024-09-06 13:54                                                       ` Sean Whitton
2024-09-06 16:32                                                         ` Philip Kaludercic
2024-09-07  9:52                                                         ` Eli Zaretskii
2024-09-07 10:10                                                           ` Philip Kaludercic
2024-09-07 21:08                                                           ` Sean Whitton
2024-09-07 21:17                                                             ` Sean Whitton
2024-09-09 17:54                                                               ` Sean Whitton
2024-09-09 19:03                                                                 ` Eli Zaretskii
2024-09-09 19:48                                                                   ` Sean Whitton
2024-09-09 19:23                                                                 ` Philip Kaludercic
2024-09-14  9:12                                                                   ` Eli Zaretskii
2024-09-14 11:27                                                                     ` Sean Whitton
2024-09-14 13:39                                                                       ` Philip Kaludercic
2024-09-14 14:05                                                                         ` Eli Zaretskii
2024-09-14 14:13                                                                           ` Philip Kaludercic
2024-09-14 14:24                                                                             ` Eli Zaretskii
2024-09-14 16:10                                                                             ` Sean Whitton
2024-09-14 16:26                                                                               ` German Pacenza
2024-09-14 16:36                                                                                 ` Sean Whitton
2024-09-14 21:19                                                                               ` Philip Kaludercic
2024-09-14 21:22                                                                                 ` Sean Whitton
2024-09-17 17:58                                                                             ` Juri Linkov
2024-09-18 16:08                                                                               ` Juri Linkov [this message]
2024-09-19  7:19                                                                               ` Philip Kaludercic
2024-09-20  6:50                                                                                 ` Juri Linkov
2024-09-20 16:57                                                                                   ` Philip Kaludercic
2024-09-08 10:38                                                             ` Philip Kaludercic
2024-05-05 16:47                   ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-03 16:20         ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86plp1osfw.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=69097@debbugs.gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).