From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73357: [PATCH] Make vc-clone interactive Date: Thu, 19 Sep 2024 16:36:12 +0300 Message-ID: <86ploz935f.fsf@gnu.org> References: <875xqrlr3b.fsf@disroot.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15668"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73357@debbugs.gnu.org To: Aleksandr Vityazev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 19 15:37:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1srHLE-0003uJ-H6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Sep 2024 15:37:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srHL2-0002dH-32; Thu, 19 Sep 2024 09:36:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srHKw-0002JJ-Pm for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 09:36:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srHKv-0004q9-4i for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 09:36:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=pgejusYwEaAwSe3J6aIjECFv8EA7jNMZ1aB+k0mQte4=; b=VjlX7kUEQ31GKCkzgmwH0WzA/JIei/h8P2mVycGykyGEGfNNYy/N+YalNI7UDJRN8HqSkhyQ9me3apw8zec5UQAPLHliyMfhMK6IvniZz/xEpjO+cSjTP4fbLAPzYPiSBdwWayEeBJaRtCoUMXmaPzVZyWcWNu9uh3k0LiMFu2/AyEF4QHR3MyFUMO5XHRxdMLDvRWrsbde9I1cPGdpsIoCRLTJNLh7b+XvHsbMyB0Tz/g21syySyLwAqJbFEuqBzjczsYyXAoLXIiQ4URx/eUJbXyiz0zGder39Diuxyjwb6zktseEEDXV12mqqAFpr1RVVgwA0m9UUvoz0tqCsGQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1srHLC-0007mH-A2 for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 09:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Sep 2024 13:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73357-submit@debbugs.gnu.org id=B73357.172675300429865 (code B ref 73357); Thu, 19 Sep 2024 13:37:02 +0000 Original-Received: (at 73357) by debbugs.gnu.org; 19 Sep 2024 13:36:44 +0000 Original-Received: from localhost ([127.0.0.1]:60069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srHKt-0007ld-F8 for submit@debbugs.gnu.org; Thu, 19 Sep 2024 09:36:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srHKq-0007lM-Q7 for 73357@debbugs.gnu.org; Thu, 19 Sep 2024 09:36:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srHKS-0004oZ-T7; Thu, 19 Sep 2024 09:36:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pgejusYwEaAwSe3J6aIjECFv8EA7jNMZ1aB+k0mQte4=; b=ixZK2zlOhlyf tmpGGMz2vGNknBuc0gcNFhi7Pj41Ni0pf4hRJFtGnlg5gLm5uLD/mKO2DUG1pgv0C/f01zbjkDJ55 T4dOmwz2CMz9fYNMBLC5wE9ZWcvNCojdjy9FMDUhm/zNIA9FyVP83aIqyGU2uRh3bpg+tkPvCz/cS jG5g3/QyZiKmWKuRgVyIOGE7CH8gRtQaGr+djX2tWyg9lTjYOk+jNgD9/BmrAFPlf7aVIGctZQVEW QIjj7bNQ/uDa6Fi4bH+zohTiMjJ23s4EDHCUREmnlD70LfHF9hyb7Ur9PHJiy7l2dBa5NiBXCJrbM MPt9SFwOVI0Mg+jmmDOdKg==; In-Reply-To: <875xqrlr3b.fsf@disroot.org> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292050 Archived-At: > Date: Thu, 19 Sep 2024 16:18:16 +0300 > From: Aleksandr Vityazev via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Cloning is used quite often, so I would like to have an interactive > command. A patch is attached to the email. WDYT? Thanks, but making this function a command will take more than just adding the interactive form. I think we need at least: . mention that in interactive usage the command prompts for the argument (why do we have to prompt for REV, btw?) . announce the change in NEWS . maybe update the user manual . maybe make the command fall back to 'checkout' method if 'clone' is not supported > + (when (file-directory-p directory) > + (if (called-interactively-p 'interactive) > + (find-file directory) > + directory)))) This changes the value returned by the function from what it did before, no?