unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Joost Kremers <joostkremers@fastmail.fm>
To: "João Távora" <joaotavora@gmail.com>
Cc: 73355@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#73355: 29.4; eglot-rename reports success when it shouldn't
Date: Sun, 22 Sep 2024 00:04:52 +0200	[thread overview]
Message-ID: <86plowslx7.fsf@fastmail.fm> (raw)
In-Reply-To: <CALDnm51+7kNcCdYRr5tcaWKk-AiAKB3cm9tzJt_s7TfHQWv1LA@mail.gmail.com> ("João Távora"'s message of "Sat, 21 Sep 2024 21:15:42 +0100")

On Sat, Sep 21 2024, João Távora wrote:
> On Sat, Sep 21, 2024, 13:13 Joost Kremers <joostkremers@fastmail.fm>
> wrote:.
>
>>
>> > It's possible Eglot is just successfully applying 0 edits.
>>
>> I guess that's one way of looking at it. :-)
>>
>
> I'm say this because Eglot has no logic to check if a rename is valid or
> not. It just does what the server tells it to. If the intended rename is
> invalid, the server can error out (and Eglot will tell you this) out return
> 0 edits. Either way, the server calls all the shots.

Ah, OK, I didn't realise that. So does the server report it made 0 edits?
If it does, would it make sense to have Eglot say no changes were made?

As soon as I have some time, I'll see if I can find out a bit more and
possibly take it up with the basedpyright people.

Thanks,

Joost


-- 
Joost Kremers
Life has its moments





  reply	other threads:[~2024-09-21 22:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19 12:01 bug#73355: 29.4; eglot-rename reports success when it shouldn't Joost Kremers
2024-09-19 16:07 ` Joost Kremers
2024-09-21 10:34 ` Eli Zaretskii
2024-09-21 11:43   ` João Távora
2024-09-21 12:12     ` Joost Kremers
2024-09-21 20:15       ` João Távora
2024-09-21 22:04         ` Joost Kremers [this message]
2024-09-21 22:31           ` João Távora
2024-09-21 22:46     ` Joost Kremers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86plowslx7.fsf@fastmail.fm \
    --to=joostkremers@fastmail.fm \
    --cc=73355@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).