From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73584: 29.3; read-key Date: Sun, 13 Oct 2024 14:41:34 +0300 Message-ID: <86plo4tekx.fsf@gnu.org> References: <56f7ea1fff72be793a8026baf34e1548@jovi.net> <86v7yb11wc.fsf@gnu.org> <86h69u22y8.fsf@gnu.org> <86v7y9zpqs.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26584"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73584@debbugs.gnu.org, stefankangas@gmail.com, Emacs-hacker2023@jovi.net To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 13 13:43:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1szx08-0006ka-8a for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Oct 2024 13:43:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szwzq-00027G-IW; Sun, 13 Oct 2024 07:42:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szwzo-00026p-Fu for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 07:42:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szwzo-00088J-7A for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 07:42:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=U2VN8jtcH9QzRFE7ynMbUqK20L0zGJOQ9V+/cvz7Tuc=; b=rxGSGS4vNVlZtBax5JVhs26qDR9fwp1u173yL/CTC2XDv3jQLaKKN0SmkgsD1oGjmAl2XXefzZxl3WMVks1DGm5ZGYZmhqkdBiwwj7APtAgmGXt0Bc5QZOunkzjZ4E7gsiwZ4AwJGLBqvIFACGQrfEWfDw7jzKI1c0jtONAryxuU+lHTGSquv/tXFOC/IdJvOZ/H3MVT0ueFP7Oc2yagsZQQJxCbR5YccDpCeOnPQrFP4tIKwW2Bux+HKHvx6fRyTzAJNDgMI3vxyfo8ofsCFrQyKzaQ86eMhuL4vFlEu+NlDPXUSZk/75O5F9tJDU8XZVJba0MUhxB8x9bTYtdNAQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szx02-0004wp-HJ for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 07:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2024 11:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73584 X-GNU-PR-Package: emacs Original-Received: via spool by 73584-submit@debbugs.gnu.org id=B73584.172881972318932 (code B ref 73584); Sun, 13 Oct 2024 11:43:02 +0000 Original-Received: (at 73584) by debbugs.gnu.org; 13 Oct 2024 11:42:03 +0000 Original-Received: from localhost ([127.0.0.1]:50432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szwz4-0004vH-M0 for submit@debbugs.gnu.org; Sun, 13 Oct 2024 07:42:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szwz2-0004un-Px for 73584@debbugs.gnu.org; Sun, 13 Oct 2024 07:42:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szwyg-00083M-MV; Sun, 13 Oct 2024 07:41:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U2VN8jtcH9QzRFE7ynMbUqK20L0zGJOQ9V+/cvz7Tuc=; b=iHr473EZ0w/p aMMhcYdO6LPDXMfWJm/WgIZVJ4/P0ox8L4/DPMRKuM+cHy1d/WQjfxqMDwJ2EaiUYWdBUytiQ3cx8 RS2YHeWclwALdG4bt5MQyd2jl4wNFnKSaqb/e2ak6cje2px4m0F52f7QyzlAQ7vXV+JzcCQLsrwbN EIa/SVoNZV+GOWdPLNmlH5OLhteu7RKAVOXt2OqkuFRCHc9d28SbqEyQ0DRbsimO/XzvMAURpRUFB m1BQfTEeQBu4CHGt156B3mXfqdmlO2mUuq3rbTJBLxy6wSX3d7DpDZBFNAt+a/5byHvGS5uQd1roI QJE5/06G3zciW186nrPKxg==; In-Reply-To: (message from Stefan Monnier on Thu, 03 Oct 2024 11:43:25 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293513 Archived-At: > From: Stefan Monnier > Cc: Stefan Kangas , Emacs-hacker2023@jovi.net, > 73584@debbugs.gnu.org > Date: Thu, 03 Oct 2024 11:43:25 -0400 > > > The OP shot himself in the foot by invoking by hand a low-level > > function with a wrong argument. Interactive functions and high-level > > APIs must check their arguments right away, but low-level functions > > like this one do not. > > I think the "bug" is indeed not in the fact that we check too late for > a string. I guess we could say that any code which temporarily rebinds > the global map should be super-extra careful never to signal an error, > and prevent itself from being Edebugged etc... but it would be > preferable for the debuggers to "handle it". Is the patch below acceptable as the solution to this? diff --git a/lisp/emacs-lisp/backtrace.el b/lisp/emacs-lisp/backtrace.el index 120972d..e353970 100644 --- a/lisp/emacs-lisp/backtrace.el +++ b/lisp/emacs-lisp/backtrace.el @@ -202,6 +202,7 @@ backtrace-mode-map "+" #'backtrace-multi-line "-" #'backtrace-single-line "." #'backtrace-expand-ellipses + "C-]" #'abort-recursive-edit "" 'mouse-face "" #'mouse-select-window