From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74104: 31.0.50; 'custom-set-faces' overrides face when no theme is loaded Date: Sat, 09 Nov 2024 12:04:50 +0200 Message-ID: <86pln4n2nx.fsf@gnu.org> References: <87y125ucbz.fsf@protesilaos.com> <86plnh4n2l.fsf@gnu.org> <87wmhozvfd.fsf@protesilaos.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18098"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74104@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 09 11:06:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t9iMI-0004Tt-Pa for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Nov 2024 11:06:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9iM1-0002Le-Ed; Sat, 09 Nov 2024 05:06:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9iLz-0002LB-48 for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 05:06:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t9iLy-0006Rn-NK for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 05:06:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=cAu7FWk5o7AJ0os16WUw5xZLszdUlI9tnvnk4Em5rdw=; b=ZqH6nkueeeYE0gMr+3fMKjRDNTxj+LzefGhCm/kfq+WyrzZmw76M3Jz/g2Lx+U5ZsG2fmyGr5DNR+k8r67pC9uwN/fRvHB5QRQHQKuCgO7Qqk3xHIfOoGPn20cZV5r07v6kc9uZq6vcD7vMkQPs2oBqiHESN6tD53yNrqADl5U0oXFK/YhQtIDCpspPQZdvzmuyPtEwof4EsoLW+Td2+VpTrk7F6rjvC/CwZoPUzwqpYXL/RDTE+MysMNxvAclpwPsMUgj16yl4Lm1/uFPz8PI6LySVwTR/7qNiPJK0r/fc5SGo+8tYeFtDr7AVf4BsPP16c9QTaD4G+y0ZcoJbzGw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t9iLy-0003n8-Ho for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 05:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2024 10:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74104 X-GNU-PR-Package: emacs Original-Received: via spool by 74104-submit@debbugs.gnu.org id=B74104.173114670914375 (code B ref 74104); Sat, 09 Nov 2024 10:06:02 +0000 Original-Received: (at 74104) by debbugs.gnu.org; 9 Nov 2024 10:05:09 +0000 Original-Received: from localhost ([127.0.0.1]:53500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9iL7-0003jY-4b for submit@debbugs.gnu.org; Sat, 09 Nov 2024 05:05:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9iL4-0003fZ-SJ for 74104@debbugs.gnu.org; Sat, 09 Nov 2024 05:05:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9iKz-00069K-IR; Sat, 09 Nov 2024 05:05:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cAu7FWk5o7AJ0os16WUw5xZLszdUlI9tnvnk4Em5rdw=; b=clppmFXGVaHH xMb8y5cSYtc2O5RtfMD4+0XXO7T7cJ3UtrO0GhZLU8Ll0cZNrMJq8jJ66yosnA7RC9zdf+eSKv/Kj 1CL88hTuLucm1jSgWlqeKPGrfZgqmN034bPeFV/oHD38Qn/R+cHo4WdNMxt2BRTFa0lADyeMjlJCy AuS43jKgECNWh1Sfpxa1LeeGXo0Ki4bX5Bz7gEOgCfNUNTdCB8Ht+LQwz3Y87XQRzgyX2BbQwbSq0 fZKgKNPebf1xPYjUQwsPhI+d3VNnVniIuJNDg7atI4ErDeyssC1I5ciZ6l1b9BKBan7doLjUNEUQH VNt8/n59mCjpMxhupgWyuw==; In-Reply-To: <87wmhozvfd.fsf@protesilaos.com> (message from Protesilaos Stavrou on Thu, 31 Oct 2024 07:35:34 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295118 Archived-At: > From: Protesilaos Stavrou > Cc: 74104@debbugs.gnu.org > Date: Thu, 31 Oct 2024 07:35:34 +0200 > > > From: Eli Zaretskii > > Date: Wed, 30 Oct 2024 17:39:30 +0200 > > > >> From: Protesilaos Stavrou > >> Date: Wed, 30 Oct 2024 12:14:40 +0200 > >> > >> Dear maintainers, > >> > >> When a theme is already enabled, 'custom-set-faces' has the effect of > >> adding face attributes on top of the existing ones. Those that were > >> present are not removed: they are blended with the new ones. > >> > >> This, however, is not happening when no theme is loaded. In that > >> scenario, 'custom-set-faces' removes all the underlying face attributes > >> and keeps only those specified in the function call. I think this is a > >> mistake. > > > > custom-set-faces is used to set up customized faces in the user's init > > files: they are the forms written by Custom when the user decides to > > save the face customizations for future sessions. So I don't think > > this is a mistake, and I don't see how we can change this without > > catastrophic effects on everyone's init files. > > Indeed, I do not want to break anybody's setup or even make far-reaching > changes just for this. Do you think the difference in behaviour when a > theme is loaded versus when it is not is the intended design? Yes, I think so.