From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74844: m-buffer: Broken Top Directory node in Info manual due to malformed Texinfo direntry Date: Sat, 14 Dec 2024 16:47:37 +0200 Message-ID: <86pllutj7a.fsf@gnu.org> References: <87zfl0bc7o.fsf@gmail.com> <86frmqwusr.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23631"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, 74844@debbugs.gnu.org, suhailsingh247@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 14 15:48:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tMTRK-0005wl-Ji for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Dec 2024 15:48:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMTR6-0007PI-DT; Sat, 14 Dec 2024 09:48:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMTR4-0007Ou-K7 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2024 09:48:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMTR4-0003BC-BG for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2024 09:48:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=7pL4vrRsF6efGqslcmGHeDS9RVPOS9PJsoMLojg7mKM=; b=sTtvpVLeLRedFNsawHeWb4Uh7Ch4+bTTCb99ueUWqVK+xVCJh6mZG6beoGZGcnEppvZmQCxxSjbVGJOUAUW0P+3+syNpzw1z/LB9yjLXF9etPlXjRGDHySga2IjbA9G/mPrsQfhHIgOosFpyudICgVJIMThuOe7md7N5D4B1CY8XKq4IqdsYbVYTIhofXOpMRpWkS7SpyBz6ktTlPfhmt5kAa0Tqf1B4LweUgH3ZWosK8KSAv3tCMwBzvQe8jGr7bX/rSkjIAOF+bZNDCT7P0P5syNnTSZ4KHVulHzqYtBXZGdudkvLm3yoF4BboHzLJkCBZBCaO3fZjtUErDzSmzQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tMTR3-0005D6-Ra for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2024 09:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Dec 2024 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74844 X-GNU-PR-Package: emacs Original-Received: via spool by 74844-submit@debbugs.gnu.org id=B74844.173418767520003 (code B ref 74844); Sat, 14 Dec 2024 14:48:01 +0000 Original-Received: (at 74844) by debbugs.gnu.org; 14 Dec 2024 14:47:55 +0000 Original-Received: from localhost ([127.0.0.1]:46048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMTQw-0005CX-Sk for submit@debbugs.gnu.org; Sat, 14 Dec 2024 09:47:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMTQr-0005C1-4i for 74844@debbugs.gnu.org; Sat, 14 Dec 2024 09:47:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMTQj-00039W-Hj; Sat, 14 Dec 2024 09:47:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7pL4vrRsF6efGqslcmGHeDS9RVPOS9PJsoMLojg7mKM=; b=kjakAPWwmppM Z2SfXwM+3D25DgmodDzzFfcjoMVTGrNAs25lX3VH6p4bGeaZ51e0lvevXQd31D99ydJJI+iGAnO7s IEzKrHRFXj83V7ar5ZyqqZDRISAZtXqRL6/UGrlH2XsbS38IDJQaew3xzPP1CoC4o/ggGmYQHQam5 bvc2a+X1nzjn2zn3oOiTD7NId6Dr+03JpdP4wGCnVEPeKAoXwk+Mqcx9Bdn83RTsEIztszn0PTHlT tHEfjrARNyGLNWP2y19vqATU2pn2bXV2p7KzEZN/ZodsZY/qS7NurkPYgiEvySofI5gtCr26VwutF otgVokALiFevsgxtNc7krQ==; In-Reply-To: (message from Stefan Monnier on Sat, 14 Dec 2024 08:53:04 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297054 Archived-At: > From: Stefan Monnier > Cc: suhailsingh247@gmail.com, 74844@debbugs.gnu.org, Ihor Radchenko > > Date: Sat, 14 Dec 2024 08:53:04 -0500 > > >> > However, the @direntry as > >> > noted in the "dir" and "m-buffer-doc.info" files is "* m-buffer.doc." > >> > >> Hmm... yup. > >> I pushed to Emacs a fix for the generation of that Texinfo element in > >> `ox-texinfo.el` and to `m-buffer` I pushed another change which tries to > >> workaround that bug (for when it's used with an older Emacs). > >> > >> The patch for `ox-texinfo.el` is below. It's "obviously safe", but > >> I suspect it's too late for Emacs-30. Eli? > > > > Maybe. For now, I don't think I understand the fix. What is 'dn' in > > this snippet? The command above says something (which need to be > > fixed to follow the code change, btw), but I'm not sure it is accurate > > or complete. > > > > An entry in DIR can be either > > > > * TITLE: (FILE). DESCRIPTION > > or > > * TITLE: (FILE)NODE. DESCRIPTION > > [ Side question: Where is this documented? ] In the Texinfo manual, in the node "Menu Parts" (since the DIR file is just a giant menu). > > What is 'dn' in the above scheme? And what is 'file'? > > `dn` is your TITLE and `file` is your FILE. Then I'm not sure this is correct: + (t (format "* %s: (%s)." (or dn file) (or file dn)))))) What if FILE is nil? Can it be nil at this point? The part in the parentheses _must_ identify an Info file, with or without a node. It cannot be the TITLE, because that one can be arbitrary text. The change is simple, so once we agree that it cannot do the wrong thing, installing on emacs-30 is fine by me, assuming Ihor doesn't object.