From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: yantar92@posteo.net, 74844@debbugs.gnu.org, suhailsingh247@gmail.com
Subject: bug#74844: m-buffer: Broken Top Directory node in Info manual due to malformed Texinfo direntry
Date: Sat, 14 Dec 2024 16:47:37 +0200 [thread overview]
Message-ID: <86pllutj7a.fsf@gnu.org> (raw)
In-Reply-To: <jwva5cyxtls.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sat, 14 Dec 2024 08:53:04 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: suhailsingh247@gmail.com, 74844@debbugs.gnu.org, Ihor Radchenko
> <yantar92@posteo.net>
> Date: Sat, 14 Dec 2024 08:53:04 -0500
>
> >> > However, the @direntry as
> >> > noted in the "dir" and "m-buffer-doc.info" files is "* m-buffer.doc."
> >>
> >> Hmm... yup.
> >> I pushed to Emacs a fix for the generation of that Texinfo element in
> >> `ox-texinfo.el` and to `m-buffer` I pushed another change which tries to
> >> workaround that bug (for when it's used with an older Emacs).
> >>
> >> The patch for `ox-texinfo.el` is below. It's "obviously safe", but
> >> I suspect it's too late for Emacs-30. Eli?
> >
> > Maybe. For now, I don't think I understand the fix. What is 'dn' in
> > this snippet? The command above says something (which need to be
> > fixed to follow the code change, btw), but I'm not sure it is accurate
> > or complete.
> >
> > An entry in DIR can be either
> >
> > * TITLE: (FILE). DESCRIPTION
> > or
> > * TITLE: (FILE)NODE. DESCRIPTION
>
> [ Side question: Where is this documented? ]
In the Texinfo manual, in the node "Menu Parts" (since the DIR file is
just a giant menu).
> > What is 'dn' in the above scheme? And what is 'file'?
>
> `dn` is your TITLE and `file` is your FILE.
Then I'm not sure this is correct:
+ (t (format "* %s: (%s)." (or dn file) (or file dn))))))
What if FILE is nil? Can it be nil at this point? The part in the
parentheses _must_ identify an Info file, with or without a node. It
cannot be the TITLE, because that one can be arbitrary text.
The change is simple, so once we agree that it cannot do the wrong
thing, installing on emacs-30 is fine by me, assuming Ihor doesn't
object.
prev parent reply other threads:[~2024-12-14 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 1:31 bug#74844: 29.4; m-buffer: Broken Top Directory node in Info manual due to malformed Texinfo direntry Suhail Singh
2024-12-13 21:50 ` bug#74844: " Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-14 8:08 ` Eli Zaretskii
2024-12-14 13:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-14 14:47 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pllutj7a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74844@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=suhailsingh247@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).