From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Date: Fri, 20 Dec 2024 09:01:29 +0200 Message-ID: <86pllmkfcm.fsf@gnu.org> References: <20241219223632.37894-1-hong@topbug.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37353"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74983@debbugs.gnu.org To: Hong Xu , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 20 08:02:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOX1x-0009Sh-4K for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Dec 2024 08:02:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOX1k-0003Hr-E5; Fri, 20 Dec 2024 02:02:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOX1R-0003Ay-EO for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 02:02:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOX1O-0002Ue-EY for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 02:02:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=OO+BQUXyfl6dyVZwzFZZfT5MmGflM7AUuA882Wlm/L4=; b=nQEbjI60bn+Lq3RdLuIxcRFvhjXJ9veifNA6WLeQy/5jl6LU23DC+mSyZsL/O1exlTSsDNsP/hyBD4i/eSbPTt89f8/RYhq85DF7ymlstbOgR/sdlvY1+wUf8jT18npbAfQVcjKWCMrD65yFSL56C1U27Ttf/vhF8/KBt9U4BXXgeKAGEDCAC/pDfuVh9u75lfEqgrvC4jQBd6x5u//QTuOL+Qz43OoHn+q+wiMBcQTnZBM+xXnvkFjJqWVwNkwMoN7n8nUXuU2rcjQ7YiRDmsmKXzBZYHg0nGGNqv4OmS58RBWBIWTCATWCE/FLi1lxScENcSN9XDlgSf7x1kBqyg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOX1O-0007Rl-A0 for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 02:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Dec 2024 07:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74983-submit@debbugs.gnu.org id=B74983.173467810128585 (code B ref 74983); Fri, 20 Dec 2024 07:02:02 +0000 Original-Received: (at 74983) by debbugs.gnu.org; 20 Dec 2024 07:01:41 +0000 Original-Received: from localhost ([127.0.0.1]:41400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOX12-0007Qy-VK for submit@debbugs.gnu.org; Fri, 20 Dec 2024 02:01:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOX10-0007Qd-Lb for 74983@debbugs.gnu.org; Fri, 20 Dec 2024 02:01:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOX0t-0002PQ-Ji; Fri, 20 Dec 2024 02:01:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OO+BQUXyfl6dyVZwzFZZfT5MmGflM7AUuA882Wlm/L4=; b=A0hhfIe7m72j JR2o/e9bcbVjSmHvyJFzVhvrW0qsQnelCuD8BOeWCK4L2oKA/1U0L4cCtgfBUQxPU+LCgEVXvKJR6 nOitJqCs6U5cWch+PXRCO8Cxjkh8FnFimeM74SFJ9+awCBXSdvwp4aUryLIOIm2Yu8SF9/pfbZZYu +JIgzdi1so6tEEGF4i7YgbedFnu44UHl9briS47ESpRw+cJ+WNWb6JDYeXM/27Uh7YJH3sSQlDyPX d0eNc7JltPIB9jooRdIJLNbgIXdgMkZkR6Z/hDVA9IsZCiaG0zjl8z4gx8TnOSJe/VFSYjmtJ/ExV 3Qjwntux1f7caQcwXKZLrw==; In-Reply-To: <20241219223632.37894-1-hong@topbug.net> (message from Hong Xu on Thu, 19 Dec 2024 14:36:29 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297426 Archived-At: > From: Hong Xu > Date: Thu, 19 Dec 2024 14:36:29 -0800 > > * Since `define-key' is considered legacy and we encourage `keymap-set' > now. Thanks. But the second chunk is not really right, since we have many more define-key there than keymap-set. So my suggestion is not to _replace_ define-key with keymap-set, but instead describe _both_, explaining that as of Emacs 29 we are migrating towards keymap-set, which is preferred. Stefan, WDYT?