From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74725: 31.0.50; image-scaling-factor is ignored by create-image Date: Sat, 28 Dec 2024 14:26:47 +0200 Message-ID: <86pllcro1k.fsf@gnu.org> References: <2793f551-8715-4679-8f52-b4673dd6802d@orange.fr> <86y10rh26m.fsf@gnu.org> <87plm3ghzw.fsf@yahoo.com> <86frmyhfss.fsf@gnu.org> <87h67eha9b.fsf@yahoo.com> <86plm2fk1l.fsf@gnu.org> <86frmh8kj9.fsf@gnu.org> <87o714pnpq.fsf@yahoo.com> <86a5co6wnv.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9320"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 74725@debbugs.gnu.org, da_vid@orange.fr To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 28 13:27:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRVuQ-00028V-NJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Dec 2024 13:27:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRVuK-0003j1-1w; Sat, 28 Dec 2024 07:27:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVuJ-0003iN-0i for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 07:27:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRVuI-0005jk-JI for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 07:27:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=EyPU7A00nLYgpctHDuvS/25wjDYdbwJ3wTIU7opUPAI=; b=fyYRmXEEM69Si76+cDjGRtwcLzvk7dxBMg6vg1eErgLt80NN7ptGD/lD9ORyT7hpcTdp7wC9I+wb+2MUshG2fmDIJwd7UaOBSDftQnuSzdexQGGjp6Z0/ZfaFTehXupu67dKkpCOixwr6HSr9obJnbIfd/zewqN7O5jAF3x6yMW/72QIxX7t+vh3P+9aW6iKSrUyvwopTmuORG7MxZZuYbKHv3/Tg++DP+GaR5d0Yu203Vd4b+Oh8ox5A0HDJwvqdqQMoTITyT3cZ3gVbOW5IpR5esa25IgRXv/rMLCP83acZoHNWN0ZNeipEZkL9yyWYGMmEfpbyN55VbBNkgUSnA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRVuI-0002Em-C3 for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 07:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Dec 2024 12:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74725 X-GNU-PR-Package: emacs Original-Received: via spool by 74725-submit@debbugs.gnu.org id=B74725.17353888188586 (code B ref 74725); Sat, 28 Dec 2024 12:27:02 +0000 Original-Received: (at 74725) by debbugs.gnu.org; 28 Dec 2024 12:26:58 +0000 Original-Received: from localhost ([127.0.0.1]:49665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRVuE-0002EP-1o for submit@debbugs.gnu.org; Sat, 28 Dec 2024 07:26:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRVuC-0002EC-0q for 74725@debbugs.gnu.org; Sat, 28 Dec 2024 07:26:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVu5-0005i5-C1; Sat, 28 Dec 2024 07:26:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EyPU7A00nLYgpctHDuvS/25wjDYdbwJ3wTIU7opUPAI=; b=VfwbX5TndlCD 2nrE43ouMz0hHau/gKvbzMum562LP7jjKgiKSccHzgKMg5jI6J+e12cDbpWWqL1MLRWbhQXb7AQU2 rb/ZrHNFa0aVyMew5ZrxdPrxRf1Wu5G6VQ91yGLikEUKzcwIZWwTTESTXyBKSyFQpzEP297XYwKxY 1JFPWVhnTJ5Oie75VSw0WH/OzPMZe41tZr03KML9Kozf7lVHyUVhhr/5xRdIPONq2vKbkfElt7sQc Z7gN1oI3zlB7pf7hyKePBQZf3llpQKImH21Vh2E92+AmC4ogbEKpUXphUvZmDS8l72DUIb9JnDwSF RNIaGl6hvvE9D24wSJkwXg==; In-Reply-To: (message from Alan Third on Fri, 27 Dec 2024 12:11:33 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297896 Archived-At: > Date: Fri, 27 Dec 2024 12:11:33 +0000 > From: Alan Third > Cc: Po Lu , 74725@debbugs.gnu.org, da_vid@orange.fr > > > Alan, could you please prepare a patch (for the master branch) that > > records the scaling factor in the image cache and rejects a cache hit > > with a different scaling factor? > > Hi Eli, patch attached. Thanks, LGTM. > I named a new function image_compute_scale because most of the other > functions in that file start image_, however I wasn't sure if I should > name it compute_image_scale to mirror compute_image_size. Let me know > if you think I should change it. Static functions can have any names we see fit, so feel free to rename if you think compute_image_scale would be better. Feel free to install on master, when you are satisfied with the code.