From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: luangruo@yahoo.com, 74725@debbugs.gnu.org, da_vid@orange.fr
Subject: bug#74725: 31.0.50; image-scaling-factor is ignored by create-image
Date: Sat, 28 Dec 2024 14:26:47 +0200 [thread overview]
Message-ID: <86pllcro1k.fsf@gnu.org> (raw)
In-Reply-To: <Z26Zdek2lQMIYKXR@faroe.holly.idiocy.org> (message from Alan Third on Fri, 27 Dec 2024 12:11:33 +0000)
> Date: Fri, 27 Dec 2024 12:11:33 +0000
> From: Alan Third <alan@idiocy.org>
> Cc: Po Lu <luangruo@yahoo.com>, 74725@debbugs.gnu.org, da_vid@orange.fr
>
> > Alan, could you please prepare a patch (for the master branch) that
> > records the scaling factor in the image cache and rejects a cache hit
> > with a different scaling factor?
>
> Hi Eli, patch attached.
Thanks, LGTM.
> I named a new function image_compute_scale because most of the other
> functions in that file start image_, however I wasn't sure if I should
> name it compute_image_scale to mirror compute_image_size. Let me know
> if you think I should change it.
Static functions can have any names we see fit, so feel free to rename
if you think compute_image_scale would be better.
Feel free to install on master, when you are satisfied with the code.
next prev parent reply other threads:[~2024-12-28 12:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-07 12:13 bug#74725: 31.0.50; image-scaling-factor is ignored by create-image David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-07 12:41 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-07 14:49 ` Eli Zaretskii
2024-12-07 15:49 ` Alan Third
2024-12-07 16:21 ` Eli Zaretskii
2024-12-07 16:32 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-07 16:27 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-07 16:45 ` Eli Zaretskii
2024-12-08 0:01 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-08 6:03 ` Eli Zaretskii
2024-12-08 8:03 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-08 12:15 ` Eli Zaretskii
2024-12-21 9:14 ` Eli Zaretskii
2024-12-22 0:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22 6:48 ` Eli Zaretskii
2024-12-27 12:11 ` Alan Third
2024-12-27 16:11 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-28 12:26 ` Eli Zaretskii [this message]
2024-12-28 12:37 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pllcro1k.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74725@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=da_vid@orange.fr \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).