From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented Date: Sun, 24 Jul 2022 19:38:27 +0300 Organization: LINKOV.NET Message-ID: <86o7xe5t8o.fsf@mail.linkov.net> References: <83a69dw72m.fsf@gnu.org> <83wnchuexs.fsf@gnu.org> <865yk0g5cf.fsf@mail.linkov.net> <8635ez5yf6.fsf@mail.linkov.net> <86zgh3d64g.fsf@mail.linkov.net> <86tu79y3rn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22832"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 56535@debbugs.gnu.org, Eli Zaretskii , visuweshm@gmail.com To: Arun V Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 24 19:20:52 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFfHg-0005oG-IK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Jul 2022 19:20:52 +0200 Original-Received: from localhost ([::1]:52800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFfHf-0001N2-Gt for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Jul 2022 13:20:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFfEw-00074J-1z for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 13:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFfEv-00075z-PL for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 13:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFfEv-0003Tl-K9 for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 13:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jul 2022 17:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56535 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 56535-submit@debbugs.gnu.org id=B56535.165868307113344 (code B ref 56535); Sun, 24 Jul 2022 17:18:01 +0000 Original-Received: (at 56535) by debbugs.gnu.org; 24 Jul 2022 17:17:51 +0000 Original-Received: from localhost ([127.0.0.1]:48585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFfEk-0003T9-NA for submit@debbugs.gnu.org; Sun, 24 Jul 2022 13:17:50 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:51951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFfEj-0003Su-6J for 56535@debbugs.gnu.org; Sun, 24 Jul 2022 13:17:49 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id B1FA7FF804; Sun, 24 Jul 2022 17:17:41 +0000 (UTC) In-Reply-To: (Arun V.'s message of "Fri, 22 Jul 2022 14:39:30 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237858 Archived-At: --=-=-= Content-Type: text/plain >> It's difficult to choose self-descriptive symbols. So we need to have >> just good enough symbol names, then describe their exact meaning in the >> documentation. > > Then I guess introducing 'inc-no' and 'inc-no-ding' for incremental > wrapping should do as it preserves the meaning of the existing values. > > Just one more question. > > Why shouldn't the behaviour of 'no' and 'no-ding' be changed to handle > incremental searches as well, instead of introducing new values? Good question. The reason was to maintain "backward-compatibility". But do we really need to restrict the existing values only to C-s C-s, and not to incremental commands? In this case here is a new patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=isearch-wrap-pause-auto-repeat.patch diff --git a/lisp/isearch.el b/lisp/isearch.el index 8f480a87d9..ad30b5e514 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -2838,6 +2839,9 @@ isearch-search-and-update isearch-barrier (1+ isearch-other-end))))) (isearch-search) + (when (and (memq isearch-wrap-pause '(no no-ding)) + (not isearch-success)) + (isearch-repeat (if isearch-forward 'forward 'backward))) )) (isearch-push-state) (if isearch-op-fun (funcall isearch-op-fun)) --=-=-=--