From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 50431@debbugs.gnu.org
Subject: bug#50431: revert-buffer doesn't preserve read-onlyness
Date: Fri, 26 Aug 2022 10:17:24 +0300 [thread overview]
Message-ID: <86o7w7mooj.fsf@mail.linkov.net> (raw)
In-Reply-To: <83czcn36we.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Aug 2022 08:34:09 +0300")
>> >> Maybe minor modes should be restored after reverting?
>> >
>> > Only the minor modes that are automatically turned on when visiting
>> > the file. Reverting should produce the same effect as killing the
>> > buffer and then visiting the file anew, nothing more, nothing less.
>>
>> In the above example, `C-h C-t' `C-x x g' doesn't preserve the same state
>> as visiting the file anew with `C-h C-t'.
>>
>> > For that reason, I'm not sure the change that preserves the read-only
>> > status across reverts is correct. At the very least, it should be an
>> > opt-in feature, IMO.
>>
>> It was a regression when reverting stopped to preserve the read-only status
>> that worked in older versions.
>
> IMO, that was a mistake. It violates the notion of "reverting", at
> least in my book.
Maybe a new user option could define how to revert, with possible values:
1. keep the initial read-only status and minor modes;
2. keep the current read-only status and minor modes.
next prev parent reply other threads:[~2022-08-26 7:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 15:03 bug#50431: revert-buffer doesn't preserve read-onlyness Juri Linkov
2021-09-06 16:38 ` Glenn Morris
2021-09-07 15:52 ` Lars Ingebrigtsen
2021-09-09 3:07 ` Richard Stallman
2021-09-09 13:16 ` Lars Ingebrigtsen
2021-09-09 17:27 ` Juri Linkov
2022-08-24 11:35 ` Lars Ingebrigtsen
2022-08-24 17:12 ` Juri Linkov
2022-08-25 14:03 ` Lars Ingebrigtsen
2022-08-25 18:02 ` Juri Linkov
2022-08-25 18:55 ` Eli Zaretskii
2022-08-25 19:35 ` Juri Linkov
2022-08-26 5:34 ` Eli Zaretskii
2022-08-26 7:17 ` Juri Linkov [this message]
2022-08-26 16:10 ` Drew Adams
2022-08-26 10:41 ` Lars Ingebrigtsen
2022-08-26 10:48 ` Eli Zaretskii
2022-08-26 16:24 ` Drew Adams
2022-08-27 13:15 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o7w7mooj.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=50431@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).