From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#59311: 29.0.50; tab-bar global-mode-string affected by global-display-line-numbers Date: Sat, 19 Nov 2022 21:03:08 +0200 Organization: LINKOV.NET Message-ID: <86o7t292y3.fsf@mail.linkov.net> References: <86v8ncdbk1.fsf@mail.linkov.net> <83v8ncbqly.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7850"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 59311@debbugs.gnu.org, gabriel376@hotmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 19 20:18:07 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owTLq-0001th-Ev for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Nov 2022 20:18:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owTKq-0002mg-OE; Sat, 19 Nov 2022 14:17:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owTKo-0002gT-Sr for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 14:17:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owTKo-0005gv-KB for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 14:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owTKo-0006SK-GK for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 14:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Nov 2022 19:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59311 X-GNU-PR-Package: emacs Original-Received: via spool by 59311-submit@debbugs.gnu.org id=B59311.166888538424770 (code B ref 59311); Sat, 19 Nov 2022 19:17:02 +0000 Original-Received: (at 59311) by debbugs.gnu.org; 19 Nov 2022 19:16:24 +0000 Original-Received: from localhost ([127.0.0.1]:41456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owTKC-0006RS-Co for submit@debbugs.gnu.org; Sat, 19 Nov 2022 14:16:24 -0500 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:60351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owTJh-0006LX-74 for 59311@debbugs.gnu.org; Sat, 19 Nov 2022 14:15:53 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 7E75E100002; Sat, 19 Nov 2022 19:15:46 +0000 (UTC) In-Reply-To: <83v8ncbqly.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Nov 2022 10:42:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248369 Archived-At: >> @@ -322,6 +322,8 @@ string-pixel-width >> (with-current-buffer (get-buffer-create " *string-pixel-width*") >> + (when display-line-numbers-mode >> + (display-line-numbers-mode -1)) >> (delete-region (point-min) (point-max)) >> (insert string) >> (car (buffer-text-pixel-size nil nil t))))) > > Yes. Or subtract what (line-number-display-width t) returns (it will > return zero when line-numbers are turned OFF). Shouldn't then buffer-text-pixel-size subtract line-number-display-width? Isn't this the responsibility of buffer-text-pixel-size, not responsibility of a caller like string-pixel-width?