From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Wed, 23 Nov 2022 13:42:56 +0100 Message-ID: <86o7sxg7u7.fsf@gnu.org> References: <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <87fseqtpiu.fsf@dfreeman.email> <875yfm8lzf.fsf@gmail.com> <83wn82osoo.fsf@gnu.org> <871qq8xfzr.fsf@gmx.de> <87mt8uwo2q.fsf@dfreeman.email> <87zgcs6nvb.fsf@gmx.de> <87r0y3luad.fsf@dfreeman.email> <87iljf72ua.fsf@gmx.de> <87a64qykcf.fsf@gmx.de> <8735ab12pr.fsf@gmx.de> <720bcf72-e944-4978-982f-4b6fa8b31e5c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3917"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 Cc: Felician Nemeth , Danny Freeman , 58790@debbugs.gnu.org, Richard Copley , Michael Albinus , Stefan Kangas , Dmitry Gutov , Eli Zaretskii To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 13:44:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxp6u-0000oB-9S for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 13:44:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxp6i-0006FO-Oi; Wed, 23 Nov 2022 07:44:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxp6h-0006DI-0u for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:44:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxp6g-0000ah-Jp for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxp6g-0004CT-2e for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Arash Esbati Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166920741416104 (code B ref 58790); Wed, 23 Nov 2022 12:44:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 23 Nov 2022 12:43:34 +0000 Original-Received: from localhost ([127.0.0.1]:54076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxp6E-0004Bg-Go for submit@debbugs.gnu.org; Wed, 23 Nov 2022 07:43:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxp6A-0004BQ-M6 for 58790@debbugs.gnu.org; Wed, 23 Nov 2022 07:43:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxp64-0008Bk-BR; Wed, 23 Nov 2022 07:43:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=EiCT0u3OEsaYOFLOofn6eISvd+T3PqALNHs2GzTJz8E=; b=bCE18K6UnbNeidVgq9B5 4UlYkIlAfQJ3NC7beE2JgxypMYjplvrcQL4zOCCsB3fkDGLlP8dvIeRZmtZhVNGghj8ycrp9u4k+x 7vAjLD1tKGZr00TVtG/wkanzFv2yv3wpEcGBfHb6o2B2ItS9H+jkTlkRoQWCLU+Pqiu21jDrA9WZm 5t0ugdbm5Y8rUAr99robAhKlGo95E/8Qxjg0v0CG820Yh481l/9ScDktDO5ALHVB/TzjIKfze8asT SbGexTzfuqaEmYEnPfmFaeqo4JpsNgHBEuJ74bjVKS6ee+uKp0LtrvyUtiEkh1RTHNS3Cmie0K6Bd twAxl0V1CJaUYg==; Original-Received: from p5b326552.dip0.t-ipconnect.de ([91.50.101.82] helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxp63-0000Gz-Ru; Wed, 23 Nov 2022 07:43:24 -0500 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 23 Nov 2022 12:36:37 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248733 Archived-At: Jo=E3o T=E1vora writes: > Yes,I think I follow. To be clear I think the problem is somewhere in=20 > > (defun eglot--path-to-uri (path) > "URIfy PATH." > (let ((truepath (file-truename path))) > (if (url-type (url-generic-parse-url truepath)) > ;; Path is already a URI, so forward it to the LSP server > ;; untouched. The server should be able to handle it, since > ;; it provided this URI to clients in the first place. > truepath > ...) > > So either url-generic-parse-url and url-type is fixed in url-parse.el, or= =20 > we must add some Windows-specific guards in eglot.el. Or likely > both, since url-parse.el is not a :core ELPA package. > > Richard/Danny, can you perhaps come up with some patch? Have a look at bug#59338: Danny came up with a patch for eglot.el. https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-11/msg01510.html Best, Arash