From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60102: Move gv-expander of substring to cl-lib Date: Fri, 16 Dec 2022 09:22:10 +0200 Organization: LINKOV.NET Message-ID: <86o7s3lsnx.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2468"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 60102@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 16 08:24:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p654t-0000Sw-Dq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Dec 2022 08:24:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p654h-0007HM-5R; Fri, 16 Dec 2022 02:24:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p654c-0007Gq-Tm for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 02:24:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p654c-0003yk-7p for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 02:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p654b-0005Bd-Sq for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 02:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2022 07:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60102 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60102-submit@debbugs.gnu.org id=B60102.167117543219929 (code B ref 60102); Fri, 16 Dec 2022 07:24:01 +0000 Original-Received: (at 60102) by debbugs.gnu.org; 16 Dec 2022 07:23:52 +0000 Original-Received: from localhost ([127.0.0.1]:47664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p654S-0005BN-9T for submit@debbugs.gnu.org; Fri, 16 Dec 2022 02:23:52 -0500 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p654Q-0005BG-Go for 60102@debbugs.gnu.org; Fri, 16 Dec 2022 02:23:51 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 0F113C000F; Fri, 16 Dec 2022 07:23:41 +0000 (UTC) In-Reply-To: (Stefan Monnier via's message of "Thu, 15 Dec 2022 15:12:06 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251186 Archived-At: > The `gv-expander` of `substring` uses the `cl--set-substring` function > that's defined only in `cl-lib`, so currently, you can compile > > (setf (substring ...) ...) > > without requiring `cl-lib` but at run time it will tend to signal > a `void-function` error. > We could autoload `cl--set-substring`, but I think a better choice is to > move this `gv-expander` to `cl-lib.el`. I tried your patch by evaluating `(tab-bar-make-keymap-1)`, but it still fails with: Debugger entered--Lisp error: (void-function cl--set-substring) cl--set-substring(#("*scratch* x" 0 9 ... tab-bar-auto-width(((sep-1 menu-item " " ignore) (current-tab menu-item #("*scratch* x" 0 9 ... tab-bar-make-keymap-1() (progn (tab-bar-make-keymap-1)) elisp--eval-last-sexp(nil) eval-last-sexp(nil) funcall-interactively(eval-last-sexp nil) command-execute(eval-last-sexp) OTOH, autoloading `cl--set-substring` fixes this error.